From: Suman Anna <s-anna@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Omar Ramirez Luna <omar.ramirez@copitl.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
tony@atomide.com
Subject: Re: [patch] mailbox/omap: make mbox->irq signed for error handling
Date: Mon, 11 Nov 2013 23:07:59 +0000 [thread overview]
Message-ID: <5281634F.2050607@ti.com> (raw)
In-Reply-To: <20131107074918.GG21844@elgon.mountain>
On 11/07/2013 01:49 AM, Dan Carpenter wrote:
> There is a bug in omap2_mbox_probe() where we try do:
>
> mbox->irq = platform_get_irq(pdev, info->irq_id);
> if (mbox->irq < 0) {
>
> The problem is that mbox->irq is unsigned so the error handling doesn't
> work. I've changed it to a signed integer.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
LGTM, thanks for the fix.
regards
Suman
WARNING: multiple messages have this Message-ID (diff)
From: Suman Anna <s-anna@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Omar Ramirez Luna <omar.ramirez@copitl.com>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<tony@atomide.com>
Subject: Re: [patch] mailbox/omap: make mbox->irq signed for error handling
Date: Mon, 11 Nov 2013 17:07:59 -0600 [thread overview]
Message-ID: <5281634F.2050607@ti.com> (raw)
In-Reply-To: <20131107074918.GG21844@elgon.mountain>
On 11/07/2013 01:49 AM, Dan Carpenter wrote:
> There is a bug in omap2_mbox_probe() where we try do:
>
> mbox->irq = platform_get_irq(pdev, info->irq_id);
> if (mbox->irq < 0) {
>
> The problem is that mbox->irq is unsigned so the error handling doesn't
> work. I've changed it to a signed integer.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
LGTM, thanks for the fix.
regards
Suman
next prev parent reply other threads:[~2013-11-11 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 7:49 [patch] mailbox/omap: make mbox->irq signed for error handling Dan Carpenter
2013-11-07 7:49 ` Dan Carpenter
2013-11-11 23:07 ` Suman Anna [this message]
2013-11-11 23:07 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5281634F.2050607@ti.com \
--to=s-anna@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=omar.ramirez@copitl.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.