All of lore.kernel.org
 help / color / mirror / Atom feed
From: srinivas kandagatla <srinivas.kandagatla@st.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Landley <rob@landley.net>,
	Russell King <linux@arm.linux.org.uk>,
	Stuart Menefy <stuart.menefy@st.com>, Pavel Machek <pavel@ucw.cz>,
	Len Brown <len.brown@intel.com>,
	stephen.gallimore@st.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Grant Likely <grant.likely@linaro.org>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@stlinux.com,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH RFC 07/10] PM / wakeup : Introduce device_child_may_wakeup
Date: Tue, 12 Nov 2013 14:09:01 +0000	[thread overview]
Message-ID: <5282367D.1090705@st.com> (raw)
In-Reply-To: <4093206.klj58BXQv3@vostro.rjw.lan>

On 12/11/13 14:20, Rafael J. Wysocki wrote:
>>  
>> > +/* callback for device_child_may_wakeup */
>> > +static int __device_child_may_wakeup(struct device *dev, void *c)
>> > +{
>> > +	return device_may_wakeup(dev);
>> > +}
> This doesn't have anything to do with children in principle, so please call
> it differently.  Something like device_may_wakeup_cb() would work for me (and
> then you may not need the comment even).

Thanks Rafael, I will fix this in next version.
> 
> Thanks!
> 
>> > +
>> > +/**


WARNING: multiple messages have this Message-ID (diff)
From: srinivas.kandagatla@st.com (srinivas kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 07/10] PM / wakeup : Introduce device_child_may_wakeup
Date: Tue, 12 Nov 2013 14:09:01 +0000	[thread overview]
Message-ID: <5282367D.1090705@st.com> (raw)
In-Reply-To: <4093206.klj58BXQv3@vostro.rjw.lan>

On 12/11/13 14:20, Rafael J. Wysocki wrote:
>>  
>> > +/* callback for device_child_may_wakeup */
>> > +static int __device_child_may_wakeup(struct device *dev, void *c)
>> > +{
>> > +	return device_may_wakeup(dev);
>> > +}
> This doesn't have anything to do with children in principle, so please call
> it differently.  Something like device_may_wakeup_cb() would work for me (and
> then you may not need the comment even).

Thanks Rafael, I will fix this in next version.
> 
> Thanks!
> 
>> > +
>> > +/**

WARNING: multiple messages have this Message-ID (diff)
From: srinivas kandagatla <srinivas.kandagatla@st.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Landley <rob@landley.net>,
	Russell King <linux@arm.linux.org.uk>,
	Stuart Menefy <stuart.menefy@st.com>, Pavel Machek <pavel@ucw.cz>,
	Len Brown <len.brown@intel.com>, <stephen.gallimore@st.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Grant Likely <grant.likely@linaro.org>,
	<devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kernel@stlinux.com>,
	<linux-pm@vger.kernel.org>
Subject: Re: [PATCH RFC 07/10] PM / wakeup : Introduce device_child_may_wakeup
Date: Tue, 12 Nov 2013 14:09:01 +0000	[thread overview]
Message-ID: <5282367D.1090705@st.com> (raw)
In-Reply-To: <4093206.klj58BXQv3@vostro.rjw.lan>

On 12/11/13 14:20, Rafael J. Wysocki wrote:
>>  
>> > +/* callback for device_child_may_wakeup */
>> > +static int __device_child_may_wakeup(struct device *dev, void *c)
>> > +{
>> > +	return device_may_wakeup(dev);
>> > +}
> This doesn't have anything to do with children in principle, so please call
> it differently.  Something like device_may_wakeup_cb() would work for me (and
> then you may not need the comment even).

Thanks Rafael, I will fix this in next version.
> 
> Thanks!
> 
>> > +
>> > +/**


  reply	other threads:[~2013-11-12 14:09 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 13:51 [PATCH RFC 00/10] ARM: STi: Add dwmac glue and reset controller srinivas.kandagatla
2013-11-12 13:51 ` srinivas.kandagatla
2013-11-12 13:51 ` srinivas.kandagatla at st.com
2013-11-12 13:52 ` [PATCH RFC 01/10] drivers: reset: STi SoC system configuration reset controller support srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla at st.com
2013-11-12 13:52 ` [PATCH RFC 02/10] drivers: reset: Reset controller driver for STiH415 srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla at st.com
2013-11-12 13:52 ` [PATCH RFC 03/10] drivers: reset: Reset controller driver for STiH416 srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla at st.com
2013-11-12 13:52 ` [PATCH RFC 04/10] drivers: reset: stih415: add softreset controller srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla at st.com
2013-11-12 13:52 ` [PATCH RFC 05/10] drivers: reset: stih416: " srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla at st.com
2013-11-12 13:52 ` [PATCH RFC 06/10] ARM: STi: Add reset controller support to mach-sti Kconfig srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla at st.com
2013-11-12 13:52 ` [PATCH RFC 07/10] PM / wakeup : Introduce device_child_may_wakeup srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla
2013-11-12 13:52   ` srinivas.kandagatla at st.com
2013-11-12 14:20   ` Rafael J. Wysocki
2013-11-12 14:20     ` Rafael J. Wysocki
2013-11-12 14:09     ` srinivas kandagatla [this message]
2013-11-12 14:09       ` srinivas kandagatla
2013-11-12 14:09       ` srinivas kandagatla
2013-11-12 13:53 ` [PATCH RFC 08/10] net: stmmac:sti: Add STi SOC glue driver srinivas.kandagatla
2013-11-12 13:53   ` srinivas.kandagatla
2013-11-12 13:53   ` srinivas.kandagatla at st.com
2013-11-29 19:37   ` Maxime Ripard
2013-11-29 19:37     ` Maxime Ripard
2013-12-02 12:48     ` srinivas kandagatla
2013-12-02 12:48       ` srinivas kandagatla
2013-12-02 12:48       ` srinivas kandagatla
2013-12-06 18:37       ` Maxime Ripard
2013-12-06 18:37         ` Maxime Ripard
2013-11-12 13:53 ` [PATCH RFC 09/10] ARM: STi: Add STiH415 ethernet support srinivas.kandagatla
2013-11-12 13:53   ` srinivas.kandagatla
2013-11-12 13:53   ` srinivas.kandagatla at st.com
2013-11-12 13:53 ` [PATCH RFC 10/10] ARM: STi: Add STiH416 " srinivas.kandagatla
2013-11-12 13:53   ` srinivas.kandagatla
2013-11-12 13:53   ` srinivas.kandagatla at st.com
2013-11-19  5:28 ` [PATCH RFC 00/10] ARM: STi: Add dwmac glue and reset controller Giuseppe CAVALLARO
2013-11-19  5:28   ` Giuseppe CAVALLARO
2013-11-19  5:28   ` Giuseppe CAVALLARO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5282367D.1090705@st.com \
    --to=srinivas.kandagatla@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@stlinux.com \
    --cc=len.brown@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=pawel.moll@arm.com \
    --cc=peppe.cavallaro@st.com \
    --cc=rjw@rjwysocki.net \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=stephen.gallimore@st.com \
    --cc=stuart.menefy@st.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.