From: Eric Sandeen <sandeen@redhat.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfs_repair: suggest reboot after dangerous repair
Date: Tue, 12 Nov 2013 11:14:46 -0600 [thread overview]
Message-ID: <52826206.3080106@redhat.com> (raw)
If a "dangerous" repair (repair of a readonly mounted fs)
has been done, suggest an immediate reboot upon completion.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
TBH, I don't know how "dangerous" dangerous is. Is this
still required?
diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c
index 820e7a2..9e1a774 100644
--- a/repair/xfs_repair.c
+++ b/repair/xfs_repair.c
@@ -884,6 +884,11 @@ _("Note - stripe unit (%d) and width (%d) fields have been reset.\n"
if (verbose)
summary_report();
do_log(_("done\n"));
+
+ if (dangerously && !no_modify)
+ do_warn(
+_("Repair of readonly mount complete. Immediate reboot encouraged.\n"));
+
pftrace_done();
return (0);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2013-11-12 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 17:14 Eric Sandeen [this message]
2013-12-04 19:38 ` [PATCH] xfs_repair: suggest reboot after dangerous repair Ben Myers
2013-12-04 19:42 ` Eric Sandeen
2013-12-11 15:00 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52826206.3080106@redhat.com \
--to=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.