From: Eric Sandeen <sandeen@redhat.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_repair: suggest reboot after dangerous repair
Date: Wed, 04 Dec 2013 13:42:42 -0600 [thread overview]
Message-ID: <529F85B2.9090702@redhat.com> (raw)
In-Reply-To: <20131204193822.GU1935@sgi.com>
On 12/4/13, 1:38 PM, Ben Myers wrote:
> On Tue, Nov 12, 2013 at 11:14:46AM -0600, Eric Sandeen wrote:
>> If a "dangerous" repair (repair of a readonly mounted fs)
>> has been done, suggest an immediate reboot upon completion.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> TBH, I don't know how "dangerous" dangerous is. Is this
>> still required?
>
> Was there a crash or something after a repair that led to
> this patch?
>
> Reviewed-by: Ben Myers <bpm@sgi.com>
>
No, it was generated by a "bug" saying that it was impossible
to run fsck.xfs on a root filesystem.
That was largely an RTFM kind of thing but since it's normal
for some systems to come up w/ RO-root in rescue mode, and people
are used to being able to run e2fsck in that mode, it might be worth
adding a little help to our tool to accomplish the same thing.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-04 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 17:14 [PATCH] xfs_repair: suggest reboot after dangerous repair Eric Sandeen
2013-12-04 19:38 ` Ben Myers
2013-12-04 19:42 ` Eric Sandeen [this message]
2013-12-11 15:00 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529F85B2.9090702@redhat.com \
--to=sandeen@redhat.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.