* [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 6:36 ` Alexandre Courbot
0 siblings, 0 replies; 10+ messages in thread
From: Alexandre Courbot @ 2013-11-12 6:36 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
gnurou-Re5JQEeQqe8AvxtiuMwx3w, Alexandre Courbot
CPU reset handler was set before fuse is initialized, but
tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
tegra_init_fuse(). This patch reorders the calls so the CPU reset
handler code does not read an uninitialized variable.
Signed-off-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
arch/arm/mach-tegra/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
index 80b801a94677..0fbdadcd96b7 100644
--- a/arch/arm/mach-tegra/tegra.c
+++ b/arch/arm/mach-tegra/tegra.c
@@ -92,9 +92,9 @@ static void __init tegra_init_cache(void)
static void __init tegra_init_early(void)
{
- tegra_cpu_reset_handler_init();
tegra_apb_io_init();
tegra_init_fuse();
+ tegra_cpu_reset_handler_init();
tegra_init_cache();
tegra_powergate_init();
tegra_hotplug_init();
--
1.8.4.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 6:36 ` Alexandre Courbot
0 siblings, 0 replies; 10+ messages in thread
From: Alexandre Courbot @ 2013-11-12 6:36 UTC (permalink / raw)
To: linux-arm-kernel
CPU reset handler was set before fuse is initialized, but
tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
tegra_init_fuse(). This patch reorders the calls so the CPU reset
handler code does not read an uninitialized variable.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
arch/arm/mach-tegra/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
index 80b801a94677..0fbdadcd96b7 100644
--- a/arch/arm/mach-tegra/tegra.c
+++ b/arch/arm/mach-tegra/tegra.c
@@ -92,9 +92,9 @@ static void __init tegra_init_cache(void)
static void __init tegra_init_early(void)
{
- tegra_cpu_reset_handler_init();
tegra_apb_io_init();
tegra_init_fuse();
+ tegra_cpu_reset_handler_init();
tegra_init_cache();
tegra_powergate_init();
tegra_hotplug_init();
--
1.8.4.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 6:36 ` Alexandre Courbot
0 siblings, 0 replies; 10+ messages in thread
From: Alexandre Courbot @ 2013-11-12 6:36 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding
Cc: linux-arm-kernel, linux-tegra, linux-kernel, gnurou,
Alexandre Courbot
CPU reset handler was set before fuse is initialized, but
tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
tegra_init_fuse(). This patch reorders the calls so the CPU reset
handler code does not read an uninitialized variable.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
arch/arm/mach-tegra/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
index 80b801a94677..0fbdadcd96b7 100644
--- a/arch/arm/mach-tegra/tegra.c
+++ b/arch/arm/mach-tegra/tegra.c
@@ -92,9 +92,9 @@ static void __init tegra_init_cache(void)
static void __init tegra_init_early(void)
{
- tegra_cpu_reset_handler_init();
tegra_apb_io_init();
tegra_init_fuse();
+ tegra_cpu_reset_handler_init();
tegra_init_cache();
tegra_powergate_init();
tegra_hotplug_init();
--
1.8.4.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 20:03 ` Stephen Warren
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Warren @ 2013-11-12 20:03 UTC (permalink / raw)
To: arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Alexandre Courbot,
Stephen Warren
From: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
CPU reset handler was set before fuse is initialized, but
tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
tegra_init_fuse(). This patch reorders the calls so the CPU reset
handler code does not read an uninitialized variable.
Signed-off-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
arm-soc, if you could apply this as a fix for 3.13, that'd be great.
Thanks.
arch/arm/mach-tegra/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
index ce553d557c31..73368176c6e8 100644
--- a/arch/arm/mach-tegra/tegra.c
+++ b/arch/arm/mach-tegra/tegra.c
@@ -90,9 +90,9 @@ static void __init tegra_init_cache(void)
static void __init tegra_init_early(void)
{
- tegra_cpu_reset_handler_init();
tegra_apb_io_init();
tegra_init_fuse();
+ tegra_cpu_reset_handler_init();
tegra_init_cache();
tegra_powergate_init();
tegra_hotplug_init();
--
1.8.1.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 20:03 ` Stephen Warren
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Warren @ 2013-11-12 20:03 UTC (permalink / raw)
To: linux-arm-kernel
From: Alexandre Courbot <acourbot@nvidia.com>
CPU reset handler was set before fuse is initialized, but
tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
tegra_init_fuse(). This patch reorders the calls so the CPU reset
handler code does not read an uninitialized variable.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
arm-soc, if you could apply this as a fix for 3.13, that'd be great.
Thanks.
arch/arm/mach-tegra/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
index ce553d557c31..73368176c6e8 100644
--- a/arch/arm/mach-tegra/tegra.c
+++ b/arch/arm/mach-tegra/tegra.c
@@ -90,9 +90,9 @@ static void __init tegra_init_cache(void)
static void __init tegra_init_early(void)
{
- tegra_cpu_reset_handler_init();
tegra_apb_io_init();
tegra_init_fuse();
+ tegra_cpu_reset_handler_init();
tegra_init_cache();
tegra_powergate_init();
tegra_hotplug_init();
--
1.8.1.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: tegra: init fuse before setting reset handler
2013-11-12 6:36 ` Alexandre Courbot
(?)
@ 2013-11-12 20:04 ` Stephen Warren
-1 siblings, 0 replies; 10+ messages in thread
From: Stephen Warren @ 2013-11-12 20:04 UTC (permalink / raw)
To: Alexandre Courbot, Thierry Reding
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
gnurou-Re5JQEeQqe8AvxtiuMwx3w
On 11/11/2013 11:36 PM, Alexandre Courbot wrote:
> CPU reset handler was set before fuse is initialized, but
> tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
> tegra_init_fuse(). This patch reorders the calls so the CPU reset
> handler code does not read an uninitialized variable.
Thanks. I forwarded this to the arm-soc maintainers as a patch for 3.13.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 20:04 ` Stephen Warren
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Warren @ 2013-11-12 20:04 UTC (permalink / raw)
To: linux-arm-kernel
On 11/11/2013 11:36 PM, Alexandre Courbot wrote:
> CPU reset handler was set before fuse is initialized, but
> tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
> tegra_init_fuse(). This patch reorders the calls so the CPU reset
> handler code does not read an uninitialized variable.
Thanks. I forwarded this to the arm-soc maintainers as a patch for 3.13.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 20:04 ` Stephen Warren
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Warren @ 2013-11-12 20:04 UTC (permalink / raw)
To: Alexandre Courbot, Thierry Reding
Cc: linux-arm-kernel, linux-tegra, linux-kernel, gnurou
On 11/11/2013 11:36 PM, Alexandre Courbot wrote:
> CPU reset handler was set before fuse is initialized, but
> tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
> tegra_init_fuse(). This patch reorders the calls so the CPU reset
> handler code does not read an uninitialized variable.
Thanks. I forwarded this to the arm-soc maintainers as a patch for 3.13.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: tegra: init fuse before setting reset handler
2013-11-12 20:03 ` Stephen Warren
@ 2013-11-12 20:43 ` Olof Johansson
-1 siblings, 0 replies; 10+ messages in thread
From: Olof Johansson @ 2013-11-12 20:43 UTC (permalink / raw)
To: Stephen Warren
Cc: arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Alexandre Courbot, Stephen Warren
On Tue, Nov 12, 2013 at 12:03 PM, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
> From: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> CPU reset handler was set before fuse is initialized, but
> tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
> tegra_init_fuse(). This patch reorders the calls so the CPU reset
> handler code does not read an uninitialized variable.
>
> Signed-off-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> arm-soc, if you could apply this as a fix for 3.13, that'd be great.
> Thanks.
Done!
-Olof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: tegra: init fuse before setting reset handler
@ 2013-11-12 20:43 ` Olof Johansson
0 siblings, 0 replies; 10+ messages in thread
From: Olof Johansson @ 2013-11-12 20:43 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 12, 2013 at 12:03 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Alexandre Courbot <acourbot@nvidia.com>
>
> CPU reset handler was set before fuse is initialized, but
> tegra_cpu_reset_handler_enable() uses tegra_chip_id, which is set by
> tegra_init_fuse(). This patch reorders the calls so the CPU reset
> handler code does not read an uninitialized variable.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> arm-soc, if you could apply this as a fix for 3.13, that'd be great.
> Thanks.
Done!
-Olof
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-11-12 20:43 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-12 6:36 [PATCH] ARM: tegra: init fuse before setting reset handler Alexandre Courbot
2013-11-12 6:36 ` Alexandre Courbot
2013-11-12 6:36 ` Alexandre Courbot
[not found] ` <1384238186-8473-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-12 20:04 ` Stephen Warren
2013-11-12 20:04 ` Stephen Warren
2013-11-12 20:04 ` Stephen Warren
-- strict thread matches above, loose matches on Subject: below --
2013-11-12 20:03 Stephen Warren
2013-11-12 20:03 ` Stephen Warren
[not found] ` <1384286596-13761-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-12 20:43 ` Olof Johansson
2013-11-12 20:43 ` Olof Johansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.