From: Wolfgang Grandegger <wg@grandegger.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
netdev@vger.kernel.org, mkl@pengutronix.de,
linux-can@vger.kernel.org
Cc: linux-sh@vger.kernel.org, vksavl@gmail.com
Subject: Re: [PATCH] can: add Renesas R-Car CAN driver
Date: Tue, 12 Nov 2013 23:17:43 +0100 [thread overview]
Message-ID: <5282A907.6090404@grandegger.com> (raw)
In-Reply-To: <5282A17C.1030309@cogentembedded.com>
Hi Sergei,
On 11/12/2013 10:45 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 11/09/2013 04:02 AM, Sergei Shtylyov wrote:
>
>>>>> 2. ... with short-circuited CAN high and low and doing some time later
>>>>> a manual recovery with "ip link set can0 type can restart"
>
>>>> Now we have auto recovery only. Manual recovery was tested with the
>>>> first driver version and worked.
>
>>> What do you mean with "auto recovery"? Auto recovery by the hardware or
>>> via "restart-ms <ms>"? How do you choose between "manual" and "auto"
>>> recovery?
>
>> This exact test was done with hardware auto-recovery only. No
>> "restart-ms"
>> was programmed.
>
>>>> Terminal 1:
>
>>>> root@10.0.0.104:/opt/can-utils# ./cangen -n 1 -g 1 can0
>>>> root@10.0.0.104:/opt/can-utils# ./cangen -n 1 -g 1 can0
>>>> root@10.0.0.104:/opt/can-utils# ./cangen -n 1 -g 1 can0
>>>> root@10.0.0.104:/opt/can-utils#
>
>>>> Terminal 2:
>
>>>> root@10.0.0.104:/opt/can-utils# ./candump -td -e any,0:0,#FFFFFFFF
>>>> (000.000000) can0 2000008C [8] 00 00 08 00 00 00 00 00 ERRORFRAME
>>>> controller-problem{}
>>>> protocol-violation{{tx-dominant-bit-error}{}}
>>>> bus-error
>>>> (000.021147) can0 20000144 [8] 00 00 00 00 00 00 00 00 ERRORFRAME
>>>> controller-problem{}
>>>> bus-off
>>>> restarted-after-bus-off
>
>>> Why does it get "restarted" directly after the bus-off?
>
>> Because we have hardware auto-recovery enabled.
>
>>>> (011.738522) can0 2000008C [8] 00 00 08 00 00 00 00 00 ERRORFRAME
>>>> controller-problem{}
>
>>> What controller problem? data[1] is not set for some reasom.
>
>> Not comments. Looking into it.
>
> Sorry, this has been fixed a while ago. Now the log looks like:
>
> root@10.0.0.104:/opt/can-utils# ./candump -td -e any,0:0,#FFFFFFFF
> (000.000000) can0 2000008C [8] 00 28 08 00 00 00 88 00 ERRORFRAME
> controller-problem{tx-error-warning,tx-error-passive}
Only the highest level should be reported.
> protocol-violation{{tx-dominant-bit-error}{}}
> bus-error
> error-counter-tx-rx{{136}{0}}
> (000.007578) can0 20000040 [8] 00 00 00 00 00 00 00 00 ERRORFRAME
> bus-off
> (000.091847) can0 20000100 [8] 00 00 00 00 00 00 00 00 ERRORFRAME
> restarted-after-bus-off
> (056.136722) can0 2000008C [8] 00 28 08 00 00 00 88 00 ERRORFRAME
> controller-problem{tx-error-warning,tx-error-passive}
Ditto.
Wolfgang.
WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg@grandegger.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
netdev@vger.kernel.org, mkl@pengutronix.de,
linux-can@vger.kernel.org
Cc: linux-sh@vger.kernel.org, vksavl@gmail.com
Subject: Re: [PATCH] can: add Renesas R-Car CAN driver
Date: Tue, 12 Nov 2013 22:17:43 +0000 [thread overview]
Message-ID: <5282A907.6090404@grandegger.com> (raw)
In-Reply-To: <5282A17C.1030309@cogentembedded.com>
Hi Sergei,
On 11/12/2013 10:45 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 11/09/2013 04:02 AM, Sergei Shtylyov wrote:
>
>>>>> 2. ... with short-circuited CAN high and low and doing some time later
>>>>> a manual recovery with "ip link set can0 type can restart"
>
>>>> Now we have auto recovery only. Manual recovery was tested with the
>>>> first driver version and worked.
>
>>> What do you mean with "auto recovery"? Auto recovery by the hardware or
>>> via "restart-ms <ms>"? How do you choose between "manual" and "auto"
>>> recovery?
>
>> This exact test was done with hardware auto-recovery only. No
>> "restart-ms"
>> was programmed.
>
>>>> Terminal 1:
>
>>>> root@10.0.0.104:/opt/can-utils# ./cangen -n 1 -g 1 can0
>>>> root@10.0.0.104:/opt/can-utils# ./cangen -n 1 -g 1 can0
>>>> root@10.0.0.104:/opt/can-utils# ./cangen -n 1 -g 1 can0
>>>> root@10.0.0.104:/opt/can-utils#
>
>>>> Terminal 2:
>
>>>> root@10.0.0.104:/opt/can-utils# ./candump -td -e any,0:0,#FFFFFFFF
>>>> (000.000000) can0 2000008C [8] 00 00 08 00 00 00 00 00 ERRORFRAME
>>>> controller-problem{}
>>>> protocol-violation{{tx-dominant-bit-error}{}}
>>>> bus-error
>>>> (000.021147) can0 20000144 [8] 00 00 00 00 00 00 00 00 ERRORFRAME
>>>> controller-problem{}
>>>> bus-off
>>>> restarted-after-bus-off
>
>>> Why does it get "restarted" directly after the bus-off?
>
>> Because we have hardware auto-recovery enabled.
>
>>>> (011.738522) can0 2000008C [8] 00 00 08 00 00 00 00 00 ERRORFRAME
>>>> controller-problem{}
>
>>> What controller problem? data[1] is not set for some reasom.
>
>> Not comments. Looking into it.
>
> Sorry, this has been fixed a while ago. Now the log looks like:
>
> root@10.0.0.104:/opt/can-utils# ./candump -td -e any,0:0,#FFFFFFFF
> (000.000000) can0 2000008C [8] 00 28 08 00 00 00 88 00 ERRORFRAME
> controller-problem{tx-error-warning,tx-error-passive}
Only the highest level should be reported.
> protocol-violation{{tx-dominant-bit-error}{}}
> bus-error
> error-counter-tx-rx{{136}{0}}
> (000.007578) can0 20000040 [8] 00 00 00 00 00 00 00 00 ERRORFRAME
> bus-off
> (000.091847) can0 20000100 [8] 00 00 00 00 00 00 00 00 ERRORFRAME
> restarted-after-bus-off
> (056.136722) can0 2000008C [8] 00 28 08 00 00 00 88 00 ERRORFRAME
> controller-problem{tx-error-warning,tx-error-passive}
Ditto.
Wolfgang.
next prev parent reply other threads:[~2013-11-12 22:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 22:11 [PATCH] can: add Renesas R-Car CAN driver Sergei Shtylyov
2013-09-27 22:11 ` Sergei Shtylyov
2013-09-28 0:40 ` Joe Perches
2013-09-28 0:40 ` Joe Perches
2013-09-28 0:45 ` Stephen Hemminger
2013-09-28 0:45 ` Stephen Hemminger
2013-09-28 0:52 ` Sergei Shtylyov
2013-09-28 0:52 ` Sergei Shtylyov
2013-09-29 19:03 ` Marc Kleine-Budde
2013-09-29 19:03 ` Marc Kleine-Budde
2013-10-17 21:54 ` Sergei Shtylyov
2013-10-17 21:54 ` Sergei Shtylyov
2013-10-02 6:09 ` Wolfgang Grandegger
2013-10-02 6:09 ` Wolfgang Grandegger
2013-10-17 22:16 ` Sergei Shtylyov
2013-10-17 22:16 ` Sergei Shtylyov
2013-10-21 19:12 ` Wolfgang Grandegger
2013-10-21 19:12 ` Wolfgang Grandegger
2013-11-09 0:02 ` Sergei Shtylyov
2013-11-09 1:02 ` Sergei Shtylyov
2013-11-09 10:53 ` Wolfgang Grandegger
2013-11-09 10:53 ` Wolfgang Grandegger
2013-11-09 14:47 ` Wolfgang Grandegger
2013-11-09 14:47 ` Wolfgang Grandegger
2013-11-12 20:45 ` Sergei Shtylyov
2013-11-12 21:45 ` Sergei Shtylyov
2013-11-12 22:17 ` Wolfgang Grandegger [this message]
2013-11-12 22:17 ` Wolfgang Grandegger
2013-10-05 17:57 ` Wolfgang Grandegger
2013-10-05 17:57 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5282A907.6090404@grandegger.com \
--to=wg@grandegger.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vksavl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.