All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: perf tip: fails to convert comm
Date: Tue, 12 Nov 2013 21:58:29 -0700	[thread overview]
Message-ID: <528306F5.8050307@gmail.com> (raw)

Hi Namhyung and Frederic:

If you recall I mentioned noting a problem with the callchain series 
showing comm's. Well, it fails on acme's perf/core. git bisect points to:

$ git bisect bad
4dfced359fbc719a35527416f1b4b3999647f68b is the first bad commit
commit 4dfced359fbc719a35527416f1b4b3999647f68b
Author: Namhyung Kim <namhyung.kim@lge.com>
Date:   Fri Sep 13 16:28:57 2013 +0900

     perf tools: Get current comm instead of last one

     At insert time, a hist entry should reference comm at the time 
otherwise
     it'll get the last comm anyway.


How to re-create:

Start point is tools/perf directory for 3.12 (Linus tree):
   $ perf sched record -o /tmp/perf.data -g -- make -j 16
   $ perf script -i /tmp/perf.data > /tmp/1

cd to Arnaldo's tree, make perf and use it to create /tmp/2:
   $ perf script -i /tmp/perf.data > /tmp/1
   $ diff -U3 /tmp/1 /tmp/2 | less

You'll see a number of comm's showing as :<pid> instead of make, etc.

David

             reply	other threads:[~2013-11-13  4:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13  4:58 David Ahern [this message]
2013-11-13 18:03 ` perf tip: fails to convert comm Frederic Weisbecker
2013-11-13 18:06   ` David Ahern
2013-11-13 18:30     ` Frederic Weisbecker
2013-11-13 18:07   ` Arnaldo Carvalho de Melo
2013-11-13 18:29     ` Frederic Weisbecker
2013-11-15 16:29   ` David Ahern
2013-11-16  1:02     ` Frederic Weisbecker
2013-11-16 11:53       ` Namhyung Kim
2013-11-16 15:18       ` David Ahern
2013-11-20 13:55       ` [tip:perf/urgent] perf tools: Tag thread comm as overriden tip-bot for Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528306F5.8050307@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.