From: David Ahern <dsahern@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: perf tip: fails to convert comm
Date: Sat, 16 Nov 2013 08:18:44 -0700 [thread overview]
Message-ID: <52878CD4.5080307@gmail.com> (raw)
In-Reply-To: <20131116010207.GA18855@localhost.localdomain>
On 11/15/13, 6:02 PM, Frederic Weisbecker wrote:
> On Fri, Nov 15, 2013 at 09:29:51AM -0700, David Ahern wrote:
>> HI Frederic:
>>
>> On 11/13/13, 11:03 AM, Frederic Weisbecker wrote:
>>>
>>> I see. I can reproduce, I'll check and see what happens. It would be nice if
>>> we could have an option to dump internal perf events like comm events as well
>>> in the perf script stream.
>>
>> Any progress on a solution? This is a regression in 3.13.
>
> So the problem is that when a thread overrides its default ":%pid" comm, we forget
> to tag the thread comm as overriden. Hence, this overriden comm is not inherited on
> future forks.
>
> So here is a fix. Tell me if you see more issue, I'll cook a proper changelog and
> resend if everyting looks good.
That works for me. Thank you.
Tested-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2013-11-16 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 4:58 perf tip: fails to convert comm David Ahern
2013-11-13 18:03 ` Frederic Weisbecker
2013-11-13 18:06 ` David Ahern
2013-11-13 18:30 ` Frederic Weisbecker
2013-11-13 18:07 ` Arnaldo Carvalho de Melo
2013-11-13 18:29 ` Frederic Weisbecker
2013-11-15 16:29 ` David Ahern
2013-11-16 1:02 ` Frederic Weisbecker
2013-11-16 11:53 ` Namhyung Kim
2013-11-16 15:18 ` David Ahern [this message]
2013-11-20 13:55 ` [tip:perf/urgent] perf tools: Tag thread comm as overriden tip-bot for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52878CD4.5080307@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.