All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW
Date: Wed, 13 Nov 2013 15:53:35 +0400	[thread overview]
Message-ID: <5283683F.9020102@msgid.tls.msk.ru> (raw)
In-Reply-To: <1384105751-12815-1-git-send-email-sw@weilnetz.de>

10.11.2013 21:49, Stefan Weil wrote:
> While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny
> (gcc-mingw32 4.4.2-3) shows these errors:

I guess you mean Debian lenny, not Ubuntu lenny here ;)  And lenny
is an "old-old-stable" Debian release - it was before squeeze which
is now oldstable.  Lenny has been released at 14 Feb 2009...

> In file included from qga/vss-win32.c:17:
> qga/vss-win32/requester.h:31:
>  error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_init«
> qga/vss-win32/requester.h:32:
>  error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_deinit«
> 
> The macro STDAPI is unknown, so add the missing include file which
> defines it.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> This patch also fixes the same error on the MinGW buildbot.
> I did not notice it earlier because I usually compile with MinGW-w64.
> 
> Regards,
> Stefan
> 
>  qga/vss-win32/requester.h |    1 +
>  1 file changed, 1 insertion(+)

Thanks, applied to the trivial-patches queue, with s/Ubuntu/Debian/ - hopefully
this is okay :)

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW
Date: Wed, 13 Nov 2013 15:53:35 +0400	[thread overview]
Message-ID: <5283683F.9020102@msgid.tls.msk.ru> (raw)
In-Reply-To: <1384105751-12815-1-git-send-email-sw@weilnetz.de>

10.11.2013 21:49, Stefan Weil wrote:
> While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny
> (gcc-mingw32 4.4.2-3) shows these errors:

I guess you mean Debian lenny, not Ubuntu lenny here ;)  And lenny
is an "old-old-stable" Debian release - it was before squeeze which
is now oldstable.  Lenny has been released at 14 Feb 2009...

> In file included from qga/vss-win32.c:17:
> qga/vss-win32/requester.h:31:
>  error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_init«
> qga/vss-win32/requester.h:32:
>  error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_deinit«
> 
> The macro STDAPI is unknown, so add the missing include file which
> defines it.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> This patch also fixes the same error on the MinGW buildbot.
> I did not notice it earlier because I usually compile with MinGW-w64.
> 
> Regards,
> Stefan
> 
>  qga/vss-win32/requester.h |    1 +
>  1 file changed, 1 insertion(+)

Thanks, applied to the trivial-patches queue, with s/Ubuntu/Debian/ - hopefully
this is okay :)

/mjt

  reply	other threads:[~2013-11-13 11:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-10 17:49 [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW Stefan Weil
2013-11-10 17:49 ` [Qemu-devel] " Stefan Weil
2013-11-13 11:53 ` Michael Tokarev [this message]
2013-11-13 11:53   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-11-13 17:40   ` Stefan Weil
2013-11-13 17:40     ` [Qemu-devel] " Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5283683F.9020102@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=aliguori@amazon.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.