All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-trivial] [PATCH] console: Remove unused debug code
@ 2013-11-10 14:58 ` Stefan Weil
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-11-10 14:58 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, Gerd Hoffmann, Anthony Liguori

The local function console_print_text_attributes is no longer used since
commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 ui/console.c |   33 ---------------------------------
 1 file changed, 33 deletions(-)

diff --git a/ui/console.c b/ui/console.c
index 11d5e6a..61ed219 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -410,39 +410,6 @@ static const pixman_color_t color_table_rgb[2][8] = {
     }
 };
 
-#ifdef DEBUG_CONSOLE
-static void console_print_text_attributes(TextAttributes *t_attrib, char ch)
-{
-    if (t_attrib->bold) {
-        printf("b");
-    } else {
-        printf(" ");
-    }
-    if (t_attrib->uline) {
-        printf("u");
-    } else {
-        printf(" ");
-    }
-    if (t_attrib->blink) {
-        printf("l");
-    } else {
-        printf(" ");
-    }
-    if (t_attrib->invers) {
-        printf("i");
-    } else {
-        printf(" ");
-    }
-    if (t_attrib->unvisible) {
-        printf("n");
-    } else {
-        printf(" ");
-    }
-
-    printf(" fg: %d bg: %d ch:'%2X' '%c'\n", t_attrib->fgcol, t_attrib->bgcol, ch, ch);
-}
-#endif
-
 static void vga_putcharxy(QemuConsole *s, int x, int y, int ch,
                           TextAttributes *t_attrib)
 {
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PATCH] console: Remove unused debug code
@ 2013-11-10 14:58 ` Stefan Weil
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-11-10 14:58 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, Gerd Hoffmann, Anthony Liguori

The local function console_print_text_attributes is no longer used since
commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 ui/console.c |   33 ---------------------------------
 1 file changed, 33 deletions(-)

diff --git a/ui/console.c b/ui/console.c
index 11d5e6a..61ed219 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -410,39 +410,6 @@ static const pixman_color_t color_table_rgb[2][8] = {
     }
 };
 
-#ifdef DEBUG_CONSOLE
-static void console_print_text_attributes(TextAttributes *t_attrib, char ch)
-{
-    if (t_attrib->bold) {
-        printf("b");
-    } else {
-        printf(" ");
-    }
-    if (t_attrib->uline) {
-        printf("u");
-    } else {
-        printf(" ");
-    }
-    if (t_attrib->blink) {
-        printf("l");
-    } else {
-        printf(" ");
-    }
-    if (t_attrib->invers) {
-        printf("i");
-    } else {
-        printf(" ");
-    }
-    if (t_attrib->unvisible) {
-        printf("n");
-    } else {
-        printf(" ");
-    }
-
-    printf(" fg: %d bg: %d ch:'%2X' '%c'\n", t_attrib->fgcol, t_attrib->bgcol, ch, ch);
-}
-#endif
-
 static void vga_putcharxy(QemuConsole *s, int x, int y, int ch,
                           TextAttributes *t_attrib)
 {
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Qemu-trivial] [Qemu-devel] [PATCH] console: Remove unused debug code
  2013-11-10 14:58 ` [Qemu-devel] " Stefan Weil
@ 2013-11-11  9:22   ` Gerd Hoffmann
  -1 siblings, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2013-11-11  9:22 UTC (permalink / raw)
  To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, Anthony Liguori

On So, 2013-11-10 at 15:58 +0100, Stefan Weil wrote:
> The local function console_print_text_attributes is no longer used
> since
> commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
  Gerd




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] console: Remove unused debug code
@ 2013-11-11  9:22   ` Gerd Hoffmann
  0 siblings, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2013-11-11  9:22 UTC (permalink / raw)
  To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, Anthony Liguori

On So, 2013-11-10 at 15:58 +0100, Stefan Weil wrote:
> The local function console_print_text_attributes is no longer used
> since
> commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
  Gerd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-trivial] [PATCH] console: Remove unused debug code
  2013-11-10 14:58 ` [Qemu-devel] " Stefan Weil
@ 2013-11-13 11:54   ` Michael Tokarev
  -1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-11-13 11:54 UTC (permalink / raw)
  To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, Anthony Liguori, Gerd Hoffmann

10.11.2013 18:58, Stefan Weil пишет:
> The local function console_print_text_attributes is no longer used since
> commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f.

Thanks, applied to the trivial-patches queue.

/mjt


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [Qemu-trivial] [PATCH] console: Remove unused debug code
@ 2013-11-13 11:54   ` Michael Tokarev
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-11-13 11:54 UTC (permalink / raw)
  To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, Anthony Liguori, Gerd Hoffmann

10.11.2013 18:58, Stefan Weil пишет:
> The local function console_print_text_attributes is no longer used since
> commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f.

Thanks, applied to the trivial-patches queue.

/mjt

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-11-13 11:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-10 14:58 [Qemu-trivial] [PATCH] console: Remove unused debug code Stefan Weil
2013-11-10 14:58 ` [Qemu-devel] " Stefan Weil
2013-11-11  9:22 ` [Qemu-trivial] " Gerd Hoffmann
2013-11-11  9:22   ` Gerd Hoffmann
2013-11-13 11:54 ` [Qemu-trivial] " Michael Tokarev
2013-11-13 11:54   ` [Qemu-devel] " Michael Tokarev

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.