* [Qemu-trivial] [PATCH 1/2] trace: Remove trace.h from console.h (less dependencies)
@ 2013-11-10 13:20 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-11-10 13:20 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, Gerd Hoffmann, Anthony Liguori
This reduces the dependencies on trace.h.
Only two source files which need console.h also need trace.h.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
Without this patch, 449 .o files depend on trace.h and must
be rebuild whenever the file trace-events is changed.
The patch reduces this number to 382 for the default QEMU build.
hw/display/vmware_vga.c | 1 +
include/ui/console.h | 1 -
ui/console.c | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index a6a8cdc..aba292c 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -23,6 +23,7 @@
*/
#include "hw/hw.h"
#include "hw/loader.h"
+#include "trace.h"
#include "ui/console.h"
#include "hw/pci/pci.h"
diff --git a/include/ui/console.h b/include/ui/console.h
index 98edf41..4156a87 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -6,7 +6,6 @@
#include "qapi/qmp/qdict.h"
#include "qemu/notify.h"
#include "monitor/monitor.h"
-#include "trace.h"
#include "qapi-types.h"
#include "qapi/error.h"
diff --git a/ui/console.c b/ui/console.c
index aad4fc9..11d5e6a 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -27,6 +27,7 @@
#include "qemu/timer.h"
#include "qmp-commands.h"
#include "sysemu/char.h"
+#include "trace.h"
//#define DEBUG_CONSOLE
#define DEFAULT_BACKSCROLL 512
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH 1/2] trace: Remove trace.h from console.h (less dependencies)
@ 2013-11-10 13:20 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-11-10 13:20 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, Gerd Hoffmann, Anthony Liguori
This reduces the dependencies on trace.h.
Only two source files which need console.h also need trace.h.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
Without this patch, 449 .o files depend on trace.h and must
be rebuild whenever the file trace-events is changed.
The patch reduces this number to 382 for the default QEMU build.
hw/display/vmware_vga.c | 1 +
include/ui/console.h | 1 -
ui/console.c | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index a6a8cdc..aba292c 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -23,6 +23,7 @@
*/
#include "hw/hw.h"
#include "hw/loader.h"
+#include "trace.h"
#include "ui/console.h"
#include "hw/pci/pci.h"
diff --git a/include/ui/console.h b/include/ui/console.h
index 98edf41..4156a87 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -6,7 +6,6 @@
#include "qapi/qmp/qdict.h"
#include "qemu/notify.h"
#include "monitor/monitor.h"
-#include "trace.h"
#include "qapi-types.h"
#include "qapi/error.h"
diff --git a/ui/console.c b/ui/console.c
index aad4fc9..11d5e6a 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -27,6 +27,7 @@
#include "qemu/timer.h"
#include "qmp-commands.h"
#include "sysemu/char.h"
+#include "trace.h"
//#define DEBUG_CONSOLE
#define DEFAULT_BACKSCROLL 512
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-trivial] [PATCH 2/2] trace: Remove trace.h from hw/usb/hcd-ehci.h (less dependencies)
2013-11-10 13:20 ` [Qemu-devel] " Stefan Weil
@ 2013-11-10 13:20 ` Stefan Weil
-1 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-11-10 13:20 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, Gerd Hoffmann, Anthony Liguori
This reduces the dependencies on trace.h.
Only one source file which needs hcd-ehci.h also needs trace.h.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
This patch reduces the number of .o files which depend on trace.h
in a default QEMU build from 382 to 379.
That's not a big reduction, but now there is no longer a .h file
which directly includes trace.h, so future improvements (splitting
trace headers, one header per source file, no longer compile 379
files after each change of trace-events) are easier to implement.
hw/usb/hcd-ehci.c | 1 +
hw/usb/hcd-ehci.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 22bdbf4..0ba38c9 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -28,6 +28,7 @@
*/
#include "hw/usb/hcd-ehci.h"
+#include "trace.h"
/* Capability Registers Base Address - section 2.2 */
#define CAPLENGTH 0x0000 /* 1-byte, 0x0001 reserved */
diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h
index 065c9fa..1ad4b96 100644
--- a/hw/usb/hcd-ehci.h
+++ b/hw/usb/hcd-ehci.h
@@ -21,7 +21,6 @@
#include "qemu/timer.h"
#include "hw/usb.h"
#include "monitor/monitor.h"
-#include "trace.h"
#include "sysemu/dma.h"
#include "sysemu/sysemu.h"
#include "hw/pci/pci.h"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH 2/2] trace: Remove trace.h from hw/usb/hcd-ehci.h (less dependencies)
@ 2013-11-10 13:20 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2013-11-10 13:20 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, Gerd Hoffmann, Anthony Liguori
This reduces the dependencies on trace.h.
Only one source file which needs hcd-ehci.h also needs trace.h.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
This patch reduces the number of .o files which depend on trace.h
in a default QEMU build from 382 to 379.
That's not a big reduction, but now there is no longer a .h file
which directly includes trace.h, so future improvements (splitting
trace headers, one header per source file, no longer compile 379
files after each change of trace-events) are easier to implement.
hw/usb/hcd-ehci.c | 1 +
hw/usb/hcd-ehci.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 22bdbf4..0ba38c9 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -28,6 +28,7 @@
*/
#include "hw/usb/hcd-ehci.h"
+#include "trace.h"
/* Capability Registers Base Address - section 2.2 */
#define CAPLENGTH 0x0000 /* 1-byte, 0x0001 reserved */
diff --git a/hw/usb/hcd-ehci.h b/hw/usb/hcd-ehci.h
index 065c9fa..1ad4b96 100644
--- a/hw/usb/hcd-ehci.h
+++ b/hw/usb/hcd-ehci.h
@@ -21,7 +21,6 @@
#include "qemu/timer.h"
#include "hw/usb.h"
#include "monitor/monitor.h"
-#include "trace.h"
#include "sysemu/dma.h"
#include "sysemu/sysemu.h"
#include "hw/pci/pci.h"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH 1/2] trace: Remove trace.h from console.h (less dependencies)
2013-11-10 13:20 ` [Qemu-devel] " Stefan Weil
@ 2013-11-13 11:55 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-11-13 11:55 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, Anthony Liguori, Gerd Hoffmann
10.11.2013 17:20, Stefan Weil wrote:
> This reduces the dependencies on trace.h.
> Only two source files which need console.h also need trace.h.
Thanks, applied both patches to the trivial patches queue,
after actually verifying that the result is sane ;)
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] trace: Remove trace.h from console.h (less dependencies)
@ 2013-11-13 11:55 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-11-13 11:55 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel, Anthony Liguori, Gerd Hoffmann
10.11.2013 17:20, Stefan Weil wrote:
> This reduces the dependencies on trace.h.
> Only two source files which need console.h also need trace.h.
Thanks, applied both patches to the trivial patches queue,
after actually verifying that the result is sane ;)
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-13 11:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-10 13:20 [Qemu-trivial] [PATCH 1/2] trace: Remove trace.h from console.h (less dependencies) Stefan Weil
2013-11-10 13:20 ` [Qemu-devel] " Stefan Weil
2013-11-10 13:20 ` [Qemu-trivial] [PATCH 2/2] trace: Remove trace.h from hw/usb/hcd-ehci.h " Stefan Weil
2013-11-10 13:20 ` [Qemu-devel] " Stefan Weil
2013-11-13 11:55 ` [Qemu-trivial] [PATCH 1/2] trace: Remove trace.h from console.h " Michael Tokarev
2013-11-13 11:55 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.