From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
To: Sricharan R <r.sricharan-l0cyMroinI0@public.gmane.org>,
Rajendra Nayak <rnayak-l0cyMroinI0@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
marc.zyngier-5wv7dgnIgG8@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
santosh.shilimkar-l0cyMroinI0@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH V3 7/7] ARM: DRA: Enable Crossbar IP support for DRA7XX
Date: Wed, 13 Nov 2013 09:32:44 -0600 [thread overview]
Message-ID: <52839B9C.8090707@ti.com> (raw)
In-Reply-To: <5281C0E9.8020104-l0cyMroinI0@public.gmane.org>
On 11/11/2013 11:47 PM, Sricharan R wrote:
> Hi Rajendra,
>
> On Tuesday 12 November 2013 11:11 AM, Rajendra Nayak wrote:
>> On Tuesday 05 November 2013 06:44 PM, Sricharan R wrote:
>>> Enable the crossbar IP support for DRA7xx soc.
>>>
>>> Cc: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
>>> Cc: Rajendra Nayak <rnayak-l0cyMroinI0@public.gmane.org>
>>> Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>>> Signed-off-by: Sricharan R <r.sricharan-l0cyMroinI0@public.gmane.org>
>>> ---
>>> arch/arm/mach-omap2/Kconfig | 1 +
>>> arch/arm/mach-omap2/omap4-common.c | 4 ++++
>>> 2 files changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index b5fb5f7..2086c65 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -141,6 +141,7 @@ config SOC_DRA7XX
>>> select ARM_GIC
>>> select HAVE_SMP
>>> select COMMON_CLK
>>> + select IRQ_CROSSBAR
>>>
>>> comment "OMAP Core Type"
>>> depends on ARCH_OMAP2
>>> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
>>> index 5791143..274cbfa 100644
>>> --- a/arch/arm/mach-omap2/omap4-common.c
>>> +++ b/arch/arm/mach-omap2/omap4-common.c
>>> @@ -22,6 +22,7 @@
>>> #include <linux/of_platform.h>
>>> #include <linux/export.h>
>>> #include <linux/irqchip/arm-gic.h>
>>> +#include <linux/irqchip/irq-crossbar.h>
>>> #include <linux/of_address.h>
>>> #include <linux/reboot.h>
>>>
>>> @@ -282,9 +283,12 @@ void __init omap_gic_of_init(void)
>>>
>>> skip_errata_init:
>>> omap_wakeupgen_init();
>>> + if (soc_is_dra7xx())
>>> + crossbar_init();
>> Its good if this is called irqcrossbar_init() to avoid confusion
>> with the dma crossbar which also exists in dra7 devices.
>>
> Ya makes sense. Will change this.
Also why not call it without explicit soc check? there is already
parse for of_find_matching_node(NULL, crossbar_match); to see if we
have a match in the crossbar_init. OR call it from dra7 init without
SoC check dependency?
Rationale - with more TI SoCs trending towards crossbar, we dont need
to keep adding to the soc_is checks, further, we intend to remove
soc_is checks in it's entirety..
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 7/7] ARM: DRA: Enable Crossbar IP support for DRA7XX
Date: Wed, 13 Nov 2013 09:32:44 -0600 [thread overview]
Message-ID: <52839B9C.8090707@ti.com> (raw)
In-Reply-To: <5281C0E9.8020104@ti.com>
On 11/11/2013 11:47 PM, Sricharan R wrote:
> Hi Rajendra,
>
> On Tuesday 12 November 2013 11:11 AM, Rajendra Nayak wrote:
>> On Tuesday 05 November 2013 06:44 PM, Sricharan R wrote:
>>> Enable the crossbar IP support for DRA7xx soc.
>>>
>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Cc: Rajendra Nayak <rnayak@ti.com>
>>> Cc: Tony Lindgren <tony@atomide.com>
>>> Signed-off-by: Sricharan R <r.sricharan@ti.com>
>>> ---
>>> arch/arm/mach-omap2/Kconfig | 1 +
>>> arch/arm/mach-omap2/omap4-common.c | 4 ++++
>>> 2 files changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index b5fb5f7..2086c65 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -141,6 +141,7 @@ config SOC_DRA7XX
>>> select ARM_GIC
>>> select HAVE_SMP
>>> select COMMON_CLK
>>> + select IRQ_CROSSBAR
>>>
>>> comment "OMAP Core Type"
>>> depends on ARCH_OMAP2
>>> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
>>> index 5791143..274cbfa 100644
>>> --- a/arch/arm/mach-omap2/omap4-common.c
>>> +++ b/arch/arm/mach-omap2/omap4-common.c
>>> @@ -22,6 +22,7 @@
>>> #include <linux/of_platform.h>
>>> #include <linux/export.h>
>>> #include <linux/irqchip/arm-gic.h>
>>> +#include <linux/irqchip/irq-crossbar.h>
>>> #include <linux/of_address.h>
>>> #include <linux/reboot.h>
>>>
>>> @@ -282,9 +283,12 @@ void __init omap_gic_of_init(void)
>>>
>>> skip_errata_init:
>>> omap_wakeupgen_init();
>>> + if (soc_is_dra7xx())
>>> + crossbar_init();
>> Its good if this is called irqcrossbar_init() to avoid confusion
>> with the dma crossbar which also exists in dra7 devices.
>>
> Ya makes sense. Will change this.
Also why not call it without explicit soc check? there is already
parse for of_find_matching_node(NULL, crossbar_match); to see if we
have a match in the crossbar_init. OR call it from dra7 init without
SoC check dependency?
Rationale - with more TI SoCs trending towards crossbar, we dont need
to keep adding to the soc_is checks, further, we intend to remove
soc_is checks in it's entirety..
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Sricharan R <r.sricharan@ti.com>, Rajendra Nayak <rnayak@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-doc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linus.walleij@linaro.org>,
<linux@arm.linux.org.uk>, <tony@atomide.com>,
<marc.zyngier@arm.com>, <grant.likely@linaro.org>,
<mark.rutland@arm.com>, <robherring2@gmail.com>,
<tglx@linutronix.de>, <santosh.shilimkar@ti.com>,
<galak@codeaurora.org>
Subject: Re: [PATCH V3 7/7] ARM: DRA: Enable Crossbar IP support for DRA7XX
Date: Wed, 13 Nov 2013 09:32:44 -0600 [thread overview]
Message-ID: <52839B9C.8090707@ti.com> (raw)
In-Reply-To: <5281C0E9.8020104@ti.com>
On 11/11/2013 11:47 PM, Sricharan R wrote:
> Hi Rajendra,
>
> On Tuesday 12 November 2013 11:11 AM, Rajendra Nayak wrote:
>> On Tuesday 05 November 2013 06:44 PM, Sricharan R wrote:
>>> Enable the crossbar IP support for DRA7xx soc.
>>>
>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Cc: Rajendra Nayak <rnayak@ti.com>
>>> Cc: Tony Lindgren <tony@atomide.com>
>>> Signed-off-by: Sricharan R <r.sricharan@ti.com>
>>> ---
>>> arch/arm/mach-omap2/Kconfig | 1 +
>>> arch/arm/mach-omap2/omap4-common.c | 4 ++++
>>> 2 files changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index b5fb5f7..2086c65 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -141,6 +141,7 @@ config SOC_DRA7XX
>>> select ARM_GIC
>>> select HAVE_SMP
>>> select COMMON_CLK
>>> + select IRQ_CROSSBAR
>>>
>>> comment "OMAP Core Type"
>>> depends on ARCH_OMAP2
>>> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
>>> index 5791143..274cbfa 100644
>>> --- a/arch/arm/mach-omap2/omap4-common.c
>>> +++ b/arch/arm/mach-omap2/omap4-common.c
>>> @@ -22,6 +22,7 @@
>>> #include <linux/of_platform.h>
>>> #include <linux/export.h>
>>> #include <linux/irqchip/arm-gic.h>
>>> +#include <linux/irqchip/irq-crossbar.h>
>>> #include <linux/of_address.h>
>>> #include <linux/reboot.h>
>>>
>>> @@ -282,9 +283,12 @@ void __init omap_gic_of_init(void)
>>>
>>> skip_errata_init:
>>> omap_wakeupgen_init();
>>> + if (soc_is_dra7xx())
>>> + crossbar_init();
>> Its good if this is called irqcrossbar_init() to avoid confusion
>> with the dma crossbar which also exists in dra7 devices.
>>
> Ya makes sense. Will change this.
Also why not call it without explicit soc check? there is already
parse for of_find_matching_node(NULL, crossbar_match); to see if we
have a match in the crossbar_init. OR call it from dra7 init without
SoC check dependency?
Rationale - with more TI SoCs trending towards crossbar, we dont need
to keep adding to the soc_is checks, further, we intend to remove
soc_is checks in it's entirety..
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-11-13 15:32 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 13:14 [PATCH V3 0/7] DRIVERS: IRQCHIP: Add support for crossbar IP Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-05 13:14 ` [PATCH V3 1/7] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-05 13:14 ` Sricharan R
[not found] ` <1383657257-3458-2-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2013-11-13 15:24 ` Santosh Shilimkar
2013-11-13 15:24 ` Santosh Shilimkar
2013-11-13 15:24 ` Santosh Shilimkar
2013-11-13 15:32 ` Sricharan R
2013-11-13 15:32 ` Sricharan R
2013-11-13 15:32 ` Sricharan R
2013-11-05 13:14 ` [PATCH V3 2/7] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-13 15:27 ` Santosh Shilimkar
2013-11-13 15:27 ` Santosh Shilimkar
2013-11-13 15:27 ` Santosh Shilimkar
2013-11-05 13:14 ` [PATCH V3 3/7] ARM: DTS: DRA: Add crossbar device binding Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-13 15:27 ` Santosh Shilimkar
2013-11-13 15:27 ` Santosh Shilimkar
2013-11-13 15:27 ` Santosh Shilimkar
2013-11-05 13:14 ` [PATCH V3 4/7] ARM: DTS: DRA: Replace peripheral interrupt numbers with crossbar inputs Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-13 15:29 ` Santosh Shilimkar
2013-11-13 15:29 ` Santosh Shilimkar
2013-11-13 15:29 ` Santosh Shilimkar
[not found] ` <1383657257-3458-1-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2013-11-05 13:14 ` [PATCH V3 5/7] ARM: DTS: DRA7: Add routable-irqs property for gic node Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-13 15:29 ` Santosh Shilimkar
2013-11-13 15:29 ` Santosh Shilimkar
2013-11-13 15:29 ` Santosh Shilimkar
2013-11-05 13:14 ` [PATCH V3 6/7] ARM: OMAP4+: Correct Wakeup-gen code to use physical irq number Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-13 15:29 ` Santosh Shilimkar
2013-11-13 15:29 ` Santosh Shilimkar
2013-11-13 15:29 ` Santosh Shilimkar
2013-11-05 13:14 ` [PATCH V3 7/7] ARM: DRA: Enable Crossbar IP support for DRA7XX Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-05 13:14 ` Sricharan R
2013-11-12 5:41 ` Rajendra Nayak
2013-11-12 5:41 ` Rajendra Nayak
2013-11-12 5:41 ` Rajendra Nayak
2013-11-12 5:47 ` Sricharan R
2013-11-12 5:47 ` Sricharan R
2013-11-12 5:47 ` Sricharan R
[not found] ` <5281C0E9.8020104-l0cyMroinI0@public.gmane.org>
2013-11-13 15:32 ` Nishanth Menon [this message]
2013-11-13 15:32 ` Nishanth Menon
2013-11-13 15:32 ` Nishanth Menon
2013-11-13 15:35 ` Sricharan R
2013-11-13 15:35 ` Sricharan R
2013-11-13 15:35 ` Sricharan R
2013-11-13 16:04 ` Santosh Shilimkar
2013-11-13 16:04 ` Santosh Shilimkar
2013-11-13 16:04 ` Santosh Shilimkar
2013-11-13 15:30 ` Santosh Shilimkar
2013-11-13 15:30 ` Santosh Shilimkar
2013-11-13 15:30 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52839B9C.8090707@ti.com \
--to=nm-l0cymroini0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=r.sricharan-l0cyMroinI0@public.gmane.org \
--cc=rnayak-l0cyMroinI0@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=santosh.shilimkar-l0cyMroinI0@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.