Re: [PATCH 0/2] iio: trivial trigger cleanups and RFC

[Jonathan Cameron <jic23@kernel.org>]

On 11/12/13 21:49, Peter Meerwald wrote:
> two trivial cleanups and a question: the behaviour of 
> iio_trigger_write_current() currently is that all strings are 
> accepted -- if the string matches a trigger's name, a new trigger
> is set for the device (given the trigger passes validation); if the
> string doesn't match a trigger's name, then the current trigger
> is unset
> 
> so arbitrary garbage can be passed and is used to unset a trigger
> (I'd have expected -EINVAL for unknown trigger names and a defined 
> value such as "" to unset) -- is this what we want?

It's ABI now so even though what you suggest is sensible, we can't really
change it.


> 
> Peter Meerwald (2):
>   iio: Minor kerneldoc fix for iio_trigger_write_current()
>   iio: Remove redundant check that new trigger is different from old
> 
>  drivers/iio/industrialio-trigger.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>