From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: Remove redundant check that new trigger is different from old
Date: Wed, 13 Nov 2013 20:37:02 +0000 [thread overview]
Message-ID: <5283E2EE.5090204@kernel.org> (raw)
In-Reply-To: <1384292987-6250-3-git-send-email-pmeerw@pmeerw.net>
On 11/12/13 21:49, Peter Meerwald wrote:
> same check is performed a new lines above
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Good catch, applied to the togreg branch of iio.git
Thanks,
> ---
> drivers/iio/industrialio-trigger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index 021d735..5bf13ed 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -356,7 +356,7 @@ static ssize_t iio_trigger_write_current(struct device *dev,
>
> indio_dev->trig = trig;
>
> - if (oldtrig && indio_dev->trig != oldtrig)
> + if (oldtrig)
> iio_trigger_put(oldtrig);
> if (indio_dev->trig)
> iio_trigger_get(indio_dev->trig);
>
next prev parent reply other threads:[~2013-11-13 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 21:49 [PATCH 0/2] iio: trivial trigger cleanups and RFC Peter Meerwald
2013-11-12 21:49 ` [PATCH 1/2] iio: Minor kerneldoc fix for iio_trigger_write_current() Peter Meerwald
2013-11-13 20:32 ` Jonathan Cameron
2013-11-12 21:49 ` [PATCH 2/2] iio: Remove redundant check that new trigger is different from old Peter Meerwald
2013-11-13 20:37 ` Jonathan Cameron [this message]
2013-11-13 20:31 ` [PATCH 0/2] iio: trivial trigger cleanups and RFC Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5283E2EE.5090204@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.