From: Daniel Borkmann <dborkman@redhat.com>
To: Chang <changxiangzhong@gmail.com>
Cc: Vlad Yasevich <vyasevich@gmail.com>,
nhorman@tuxdriver.com, davem@davemloft.net,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dreibh@simula.no
Subject: Re: [PATCH 1/1] net: sctp: bug fixing when sctp path recovers
Date: Wed, 13 Nov 2013 21:31:39 +0000 [thread overview]
Message-ID: <5283EFBB.7010409@redhat.com> (raw)
In-Reply-To: <5283EDCF.20605@gmail.com>
On 11/13/2013 10:23 PM, Chang wrote:
[...]
> Let's say the following condition
> A - the initial revision
> B - something was wrong that introduced a bug
> C - latest revision
> MyFix - fixing the bug caused by B. Shall I specify B or C in the "fixes:" tag?
>
>
> revision introduces a bug
> |
> A -> B -> C ->MyFix
> |
> latest revision
You would specify B in the "Fixes:" tag, as B introduced this bug first.
In case there is no suitable git-blame information available in the current
tree (so that bug is pre Linux-2.6.12-rc2 which I believe on a quick look
that this seems the case), you can omit that. Then, just elaborate on the
commit message, and resubmit with feedback from Vlad included, too.
Thanks !
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: Chang <changxiangzhong@gmail.com>
Cc: Vlad Yasevich <vyasevich@gmail.com>,
nhorman@tuxdriver.com, davem@davemloft.net,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dreibh@simula.no
Subject: Re: [PATCH 1/1] net: sctp: bug fixing when sctp path recovers
Date: Wed, 13 Nov 2013 22:31:39 +0100 [thread overview]
Message-ID: <5283EFBB.7010409@redhat.com> (raw)
In-Reply-To: <5283EDCF.20605@gmail.com>
On 11/13/2013 10:23 PM, Chang wrote:
[...]
> Let's say the following condition
> A - the initial revision
> B - something was wrong that introduced a bug
> C - latest revision
> MyFix - fixing the bug caused by B. Shall I specify B or C in the "fixes:" tag?
>
>
> revision introduces a bug
> |
> A -> B -> C ->MyFix
> |
> latest revision
You would specify B in the "Fixes:" tag, as B introduced this bug first.
In case there is no suitable git-blame information available in the current
tree (so that bug is pre Linux-2.6.12-rc2 which I believe on a quick look
that this seems the case), you can omit that. Then, just elaborate on the
commit message, and resubmit with feedback from Vlad included, too.
Thanks !
next prev parent reply other threads:[~2013-11-13 21:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 1:34 [PATCH 1/1] net: sctp: bug fixing when sctp path recovers Chang Xiangzhong
2013-11-13 1:34 ` Chang Xiangzhong
2013-11-13 2:37 ` Vlad Yasevich
2013-11-13 2:37 ` Vlad Yasevich
2013-11-13 2:54 ` Chang
2013-11-13 2:54 ` Chang
2013-11-13 8:44 ` Daniel Borkmann
2013-11-13 8:44 ` Daniel Borkmann
2013-11-13 19:06 ` Chang
2013-11-13 19:06 ` Chang
2013-11-13 19:10 ` Daniel Borkmann
2013-11-13 19:10 ` Daniel Borkmann
2013-11-13 20:48 ` Chang
2013-11-13 20:48 ` Chang
2013-11-13 21:23 ` Chang
2013-11-13 21:23 ` Chang
2013-11-13 21:31 ` Daniel Borkmann [this message]
2013-11-13 21:31 ` Daniel Borkmann
2013-11-13 21:39 ` Vlad Yasevich
2013-11-13 21:39 ` Vlad Yasevich
2013-11-13 14:22 ` Vlad Yasevich
2013-11-13 14:22 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5283EFBB.7010409@redhat.com \
--to=dborkman@redhat.com \
--cc=changxiangzhong@gmail.com \
--cc=davem@davemloft.net \
--cc=dreibh@simula.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.