From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH 4/4] efi: On x86-64, align the stack to a 16-byte boundary as required by ABI
Date: Thu, 14 Nov 2013 09:01:19 +0100 [thread overview]
Message-ID: <5284834F.3040604@gmail.com> (raw)
In-Reply-To: <c4661d21b73f1b40a0da056b87ca867833c087a4.1384309081.git.josh@joshtriplett.org>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
>
> diff --git a/grub-core/kern/x86_64/efi/startup.S b/grub-core/kern/x86_64/efi/startup.S
> index f86f019..94bd6ae 100644
> --- a/grub-core/kern/x86_64/efi/startup.S
> +++ b/grub-core/kern/x86_64/efi/startup.S
> @@ -29,7 +29,11 @@ start:
> _start:
> movq %rcx, EXT_C(grub_efi_image_handle)(%rip)
> movq %rdx, EXT_C(grub_efi_system_table)(%rip)
> -
> + mov %rsp, %rax
> + subq $8, %rsp
> + and $~0xf, %rsp
> + mov %rax, (%rsp)
> call EXT_C(grub_main)
> + mov (%rsp), %rsp
This would be useful if we ever returned but we never do (we call
boot_services->exit instead). Could you instead prepare a patch which
does stack alignment and removed the "ret" putting instead a comment /*
Doesn't return. */ ?
> ret
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
next prev parent reply other threads:[~2013-11-14 8:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 2:25 [PATCH 0/4] i386-efi and x86_64-efi fixes Josh Triplett
2013-11-13 2:26 ` [PATCH 1/4] efi: Fix firmware memory allocation to round to 4k pages, not 1k Josh Triplett
2013-11-18 17:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-13 2:26 ` [PATCH 2/4] efi: Fix requests to allocate GRUB_MEMORY_AVAILABLE Josh Triplett
2013-11-18 16:58 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-13 2:26 ` [PATCH 3/4] efi: Support GRUB_MMAP_MALLOC_LOW in the EFI firmware allocator Josh Triplett
2013-11-13 3:59 ` Andrey Borzenkov
2013-11-14 8:08 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-14 8:05 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-13 2:27 ` [PATCH 4/4] efi: On x86-64, align the stack to a 16-byte boundary as required by ABI Josh Triplett
2013-11-14 8:01 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-11-15 7:15 ` Jordan Justen
2013-11-15 11:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-19 13:32 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284834F.3040604@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.