From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH 4/4] efi: On x86-64, align the stack to a 16-byte boundary as required by ABI
Date: Tue, 19 Nov 2013 14:32:03 +0100 [thread overview]
Message-ID: <528B6853.6080200@gmail.com> (raw)
In-Reply-To: <c4661d21b73f1b40a0da056b87ca867833c087a4.1384309081.git.josh@joshtriplett.org>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On 13.11.2013 03:27, Josh Triplett wrote:
> 2013-11-13 Josh Triplett <josh@joshtriplett.org>
>
> * grub-core/kern/x86_64/efi/startup.S (_start): Align the stack to a
> 16-byte boundary, as required by the x86-64 ABI, before calling
> grub_main. In some cases, GCC emits code that assumes this
> alignment, which crashes if not aligned. The EFI firmware is also
> entitled to assume that stack alignment without checking.
Committed with changes, thanks.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
prev parent reply other threads:[~2013-11-19 13:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 2:25 [PATCH 0/4] i386-efi and x86_64-efi fixes Josh Triplett
2013-11-13 2:26 ` [PATCH 1/4] efi: Fix firmware memory allocation to round to 4k pages, not 1k Josh Triplett
2013-11-18 17:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-13 2:26 ` [PATCH 2/4] efi: Fix requests to allocate GRUB_MEMORY_AVAILABLE Josh Triplett
2013-11-18 16:58 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-13 2:26 ` [PATCH 3/4] efi: Support GRUB_MMAP_MALLOC_LOW in the EFI firmware allocator Josh Triplett
2013-11-13 3:59 ` Andrey Borzenkov
2013-11-14 8:08 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-14 8:05 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-13 2:27 ` [PATCH 4/4] efi: On x86-64, align the stack to a 16-byte boundary as required by ABI Josh Triplett
2013-11-14 8:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-15 7:15 ` Jordan Justen
2013-11-15 11:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-19 13:32 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528B6853.6080200@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.