[PATCH] ASoC: blackfin: Fix missing break

[PATCH] ASoC: blackfin: Fix missing break

[Takashi Iwai]

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=60768
Fixes: 4b2ffc205cb9 ('ASoC: Blackfin I2S: add 8-bit sample support')
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/blackfin/bf5xx-i2s.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/blackfin/bf5xx-i2s.c b/sound/soc/blackfin/bf5xx-i2s.c
index 9a174fc47d39..39d774839b3e 100644
--- a/sound/soc/blackfin/bf5xx-i2s.c
+++ b/sound/soc/blackfin/bf5xx-i2s.c
@@ -121,6 +121,7 @@ static int bf5xx_i2s_hw_params(struct snd_pcm_substream *substream,
 		bf5xx_i2s->tcr2 |= 7;
 		bf5xx_i2s->rcr2 |= 7;
 		sport_handle->wdsize = 1;
+		break;
 	case SNDRV_PCM_FORMAT_S16_LE:
 		bf5xx_i2s->tcr2 |= 15;
 		bf5xx_i2s->rcr2 |= 15;
-- 
1.8.4.2

Re: [PATCH] ASoC: blackfin: Fix missing break

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 659 bytes --]

On Wed, Nov 13, 2013 at 05:15:00PM +0100, Takashi Iwai wrote:
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=60768
> Fixes: 4b2ffc205cb9 ('ASoC: Blackfin I2S: add 8-bit sample support')
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Applied, though if you're going to include quite that many tags you
should probably be including something human readable as well.  At first
glance this looked like something sent by mistake.  This is partly
because of the bugzilla tag which is a bit of an innovation, it's only
been used by a few graphics things (and probably ought to have a
matching Reported-by if it is ever used).

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: blackfin: Fix missing break

[Takashi Iwai]

At Wed, 13 Nov 2013 16:47:15 +0000,
Mark Brown wrote:
> 
> On Wed, Nov 13, 2013 at 05:15:00PM +0100, Takashi Iwai wrote:
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=60768
> > Fixes: 4b2ffc205cb9 ('ASoC: Blackfin I2S: add 8-bit sample support')
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> Applied, though if you're going to include quite that many tags you
> should probably be including something human readable as well.  At first
> glance this looked like something sent by mistake.  This is partly
> because of the bugzilla tag which is a bit of an innovation, it's only
> been used by a few graphics things (and probably ought to have a
> matching Reported-by if it is ever used).

Bugzilla or BugLink tags are rather popular tags, IMO.
They've been used constantly for years.  Maybe embedded guys don't
know of this just because they hate bug trackers ;)

Reported-by tag can be added only with reporter's permission, and the
link to the bug tracker or ML archive is often far more useful of list
of random people.


Takashi

Re: [PATCH] ASoC: blackfin: Fix missing break

[Takashi Iwai]

At Wed, 13 Nov 2013 18:01:20 +0100,
Takashi Iwai wrote:
> 
> At Wed, 13 Nov 2013 16:47:15 +0000,
> Mark Brown wrote:
> > 
> > On Wed, Nov 13, 2013 at 05:15:00PM +0100, Takashi Iwai wrote:
> > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=60768
> > > Fixes: 4b2ffc205cb9 ('ASoC: Blackfin I2S: add 8-bit sample support')
> > > Cc: <stable@vger.kernel.org>
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > 
> > Applied, though if you're going to include quite that many tags you
> > should probably be including something human readable as well.  At first
> > glance this looked like something sent by mistake.  This is partly
> > because of the bugzilla tag which is a bit of an innovation, it's only
> > been used by a few graphics things (and probably ought to have a
> > matching Reported-by if it is ever used).
> 
> Bugzilla or BugLink tags are rather popular tags, IMO.
> They've been used constantly for years.  Maybe embedded guys don't
> know of this just because they hate bug trackers ;)
> 
> Reported-by tag can be added only with reporter's permission, and the
> link to the bug tracker or ML archive is often far more useful of list
> of random people.

BTW, do you have an account on bugzilla.kernel.org?
If not, please create it.  I have a gift for you.
  https://bugzilla.kernel.org/show_bug.cgi?id=64741


Takashi

Re: [PATCH] ASoC: blackfin: Fix missing break

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 340 bytes --]

On Wed, Nov 13, 2013 at 06:03:46PM +0100, Takashi Iwai wrote:

> BTW, do you have an account on bugzilla.kernel.org?
> If not, please create it.  I have a gift for you.
>   https://bugzilla.kernel.org/show_bug.cgi?id=64741

That looks to be an issue that's very specific to OMAP4 - you need
someone who works on OMAP4 to have a look at it.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: blackfin: Fix missing break

[Takashi Iwai]

At Wed, 13 Nov 2013 18:47:51 +0000,
Mark Brown wrote:
> 
> On Wed, Nov 13, 2013 at 06:03:46PM +0100, Takashi Iwai wrote:
> 
> > BTW, do you have an account on bugzilla.kernel.org?
> > If not, please create it.  I have a gift for you.
> >   https://bugzilla.kernel.org/show_bug.cgi?id=64741
> 
> That looks to be an issue that's very specific to OMAP4 - you need
> someone who works on OMAP4 to have a look at it.

OK, then could you assign to an appropriate person?
You must have a better clue.


Takashi

Re: [PATCH] ASoC: blackfin: Fix missing break

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 321 bytes --]

On Thu, Nov 14, 2013 at 07:18:21AM +0100, Takashi Iwai wrote:
> Mark Brown wrote:

> > That looks to be an issue that's very specific to OMAP4 - you need
> > someone who works on OMAP4 to have a look at it.

> OK, then could you assign to an appropriate person?
> You must have a better clue.

Peter Ujfalusi at a guess.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: blackfin: Fix missing break

[Takashi Iwai]

At Thu, 14 Nov 2013 10:08:06 +0000,
Mark Brown wrote:
> 
> On Thu, Nov 14, 2013 at 07:18:21AM +0100, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > That looks to be an issue that's very specific to OMAP4 - you need
> > > someone who works on OMAP4 to have a look at it.
> 
> > OK, then could you assign to an appropriate person?
> > You must have a better clue.
> 
> Peter Ujfalusi at a guess.

Peter, could you care the bug report below?
  https://bugzilla.kernel.org/show_bug.cgi?id=64741


Takashi

Re: [PATCH] ASoC: blackfin: Fix missing break

[Peter Ujfalusi]

Hi Takashi,

On 11/14/2013 12:49 PM, Takashi Iwai wrote:
> At Thu, 14 Nov 2013 10:08:06 +0000,
> Mark Brown wrote:
>>
>> On Thu, Nov 14, 2013 at 07:18:21AM +0100, Takashi Iwai wrote:
>>> Mark Brown wrote:
>>
>>>> That looks to be an issue that's very specific to OMAP4 - you need
>>>> someone who works on OMAP4 to have a look at it.
>>
>>> OK, then could you assign to an appropriate person?
>>> You must have a better clue.
>>
>> Peter Ujfalusi at a guess.
> 
> Peter, could you care the bug report below?
>   https://bugzilla.kernel.org/show_bug.cgi?id=64741

Sure.
Platforms using McPDM+twl6040 codec (OMAP4/5) supports 96KHz only at the moment.
This is hardware limitation and the only way to get 44.1/48 KHz supported is
to use AESS on these platforms. Unfortunately I only have AESS support out of
tree in my personal branch since it has dependency on Liam's out of tree
dynamic firmware set (which I'm rolling from kernel version to kernel version).
To use AESS one need to have the firmware as well which is again not upstream
currently.
I only have 3.12-rc1 based version of AESS support, but I'm planning to have
one for 3.12 and also for 3.13-rc1 when it comes out.

-- 
Péter

Re: [PATCH] ASoC: blackfin: Fix missing break

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 796 bytes --]

On Wed, Nov 13, 2013 at 06:01:20PM +0100, Takashi Iwai wrote:

> Bugzilla or BugLink tags are rather popular tags, IMO.

I did take a look through the logs, at least Bugzilla appears to be
specific to the graphics guys and you.  I hadn't noticed BugLink before
but that appears to be specific to Cannoical (essentially all the uses
are links to Launchpad).

> They've been used constantly for years.  Maybe embedded guys don't
> know of this just because they hate bug trackers ;)

Not terribly widely...

> Reported-by tag can be added only with reporter's permission, and the
> link to the bug tracker or ML archive is often far more useful of list
> of random people.

If someone reports a bug off-list I'd not credit them without asking but
if it's reported in public that seems a bit crazy.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]