From: James Smart <james.smart@emulex.com>
To: Felipe Pena <felipensp@gmail.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: scsi: lpfc_debugfs: Fix wrong assignment
Date: Thu, 14 Nov 2013 10:41:34 -0500 [thread overview]
Message-ID: <5284EF2E.7010600@emulex.com> (raw)
In-Reply-To: <1382138137-4088-1-git-send-email-felipensp@gmail.com>
Thanks!
Acked-by: James Smart <james.smart@emulex.com>
-- james s
On 10/18/2013 7:15 PM, Felipe Pena wrote:
> On lpfc_debugfs_initialize function the dumpHostSlim member setup happens
> when 'phba->sli_rev < LPFC_SLI_REV4' is true, however when it is false NULL
> has been assigned to debug_dumpHBASlim instead of debug_dumpHostSlim.
>
> Signed-off-by: Felipe Pena <felipensp@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
> index 60084e6..b800cc9 100644
> --- a/drivers/scsi/lpfc/lpfc_debugfs.c
> +++ b/drivers/scsi/lpfc/lpfc_debugfs.c
> @@ -4001,7 +4001,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport)
> goto debug_failed;
> }
> } else
> - phba->debug_dumpHBASlim = NULL;
> + phba->debug_dumpHostSlim = NULL;
>
> /* Setup dumpData */
> snprintf(name, sizeof(name), "dumpData");
> --
> 1.7.10.4
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: James Smart <james.smart@emulex.com>
To: Felipe Pena <felipensp@gmail.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: scsi: lpfc_debugfs: Fix wrong assignment
Date: Thu, 14 Nov 2013 10:41:34 -0500 [thread overview]
Message-ID: <5284EF2E.7010600@emulex.com> (raw)
In-Reply-To: <1382138137-4088-1-git-send-email-felipensp@gmail.com>
Thanks!
Acked-by: James Smart <james.smart@emulex.com>
-- james s
On 10/18/2013 7:15 PM, Felipe Pena wrote:
> On lpfc_debugfs_initialize function the dumpHostSlim member setup happens
> when 'phba->sli_rev < LPFC_SLI_REV4' is true, however when it is false NULL
> has been assigned to debug_dumpHBASlim instead of debug_dumpHostSlim.
>
> Signed-off-by: Felipe Pena <felipensp@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
> index 60084e6..b800cc9 100644
> --- a/drivers/scsi/lpfc/lpfc_debugfs.c
> +++ b/drivers/scsi/lpfc/lpfc_debugfs.c
> @@ -4001,7 +4001,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport)
> goto debug_failed;
> }
> } else
> - phba->debug_dumpHBASlim = NULL;
> + phba->debug_dumpHostSlim = NULL;
>
> /* Setup dumpData */
> snprintf(name, sizeof(name), "dumpData");
> --
> 1.7.10.4
>
>
>
next prev parent reply other threads:[~2013-11-14 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 23:15 [PATCH] drivers: scsi: lpfc_debugfs: Fix wrong assignment Felipe Pena
2013-11-14 15:41 ` James Smart [this message]
2013-11-14 15:41 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284EF2E.7010600@emulex.com \
--to=james.smart@emulex.com \
--cc=JBottomley@parallels.com \
--cc=felipensp@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.