From: micky_ching@realsil.com.cn (micky)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mfd: rtsx: Generify call-back operations in orderto reduce code duplication
Date: Fri, 15 Nov 2013 11:43:01 +0800 [thread overview]
Message-ID: <52859845.2020101@realsil.com.cn> (raw)
In-Reply-To: <1384421355-4434-2-git-send-email-lee.jones@linaro.org>
On 11/14/2013 05:29 PM, Lee Jones wrote:
> + if (rtl8411b_is_qfn48(pcr))
> + set_pull_ctrl_tables(rtl8411b_qfn48);
> + else
> + set_pull_ctrl_tables(rtl8411b_qfn64);
Here will cause some problem, set_pull_ctrl_tables() include not a single
statements, will make the if-else not work correctly.
--
Best Regards
Micky.
WARNING: multiple messages have this Message-ID (diff)
From: micky <micky_ching@realsil.com.cn>
To: Lee Jones <lee.jones@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <sameo@linux.intel.com>
Cc: <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/4] mfd: rtsx: Generify call-back operations in orderto reduce code duplication
Date: Fri, 15 Nov 2013 11:43:01 +0800 [thread overview]
Message-ID: <52859845.2020101@realsil.com.cn> (raw)
In-Reply-To: <1384421355-4434-2-git-send-email-lee.jones@linaro.org>
On 11/14/2013 05:29 PM, Lee Jones wrote:
> + if (rtl8411b_is_qfn48(pcr))
> + set_pull_ctrl_tables(rtl8411b_qfn48);
> + else
> + set_pull_ctrl_tables(rtl8411b_qfn64);
Here will cause some problem, set_pull_ctrl_tables() include not a single
statements, will make the if-else not work correctly.
--
Best Regards
Micky.
next prev parent reply other threads:[~2013-11-15 3:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 9:29 [PATCH 0/4] mfd: rtsx: Decrease driver size and add new device Lee Jones
2013-11-14 9:29 ` Lee Jones
2013-11-14 9:29 ` [PATCH 1/4] mfd: rtsx: Generify call-back operations in order to reduce code duplication Lee Jones
2013-11-14 9:29 ` Lee Jones
2013-11-15 3:43 ` micky [this message]
2013-11-15 3:43 ` [PATCH 1/4] mfd: rtsx: Generify call-back operations in orderto " micky
2013-11-14 9:29 ` [PATCH 2/4] mfd: rtsx: Generify the switch voltage routine Lee Jones
2013-11-14 9:29 ` Lee Jones
2013-11-15 2:59 ` micky
2013-11-15 2:59 ` micky
2013-11-15 15:37 ` Lee Jones
2013-11-15 15:37 ` Lee Jones
2013-11-14 9:29 ` [PATCH 3/4] mfd: rtsx: Add rtl8402 card reader Lee Jones
2013-11-14 9:29 ` Lee Jones
2013-11-14 9:29 ` [PATCH 4/4] mfd: rtsx: Prevent 'used uninitialised' warnings Lee Jones
2013-11-14 9:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52859845.2020101@realsil.com.cn \
--to=micky_ching@realsil.com.cn \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.