From: Jeff Liu <jeff.liu@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/6] gfs2: simplify current_tail() via list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:32:52 +0800 [thread overview]
Message-ID: <5285A3F4.4040000@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Simplify the code in current_tail() via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/gfs2/log.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 610613f..555f767 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -441,13 +441,9 @@ static unsigned int current_tail(struct gfs2_sbd *sdp)
spin_lock(&sdp->sd_ail_lock);
- if (list_empty(&sdp->sd_ail1_list)) {
- tail = sdp->sd_log_head;
- } else {
- tr = list_entry(sdp->sd_ail1_list.prev, struct gfs2_trans,
- tr_list);
- tail = tr->tr_first;
- }
+ tr = list_last_entry_or_null(&sdp->sd_ail1_list, struct gfs2_trans,
+ tr_list);
+ tail = tr ? tr->tr_first : sdp->sd_log_head;
spin_unlock(&sdp->sd_ail_lock);
--
1.8.3.2
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: jfs-discussion@lists.sourceforge.net, jiri@resnulli.us,
gregkh@linuxfoundation.org, oleg@redhat.com,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
akpm@linux-foundation.org
Subject: [PATCH 3/6] gfs2: simplify current_tail() via list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:32:52 +0800 [thread overview]
Message-ID: <5285A3F4.4040000@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Simplify the code in current_tail() via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/gfs2/log.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 610613f..555f767 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -441,13 +441,9 @@ static unsigned int current_tail(struct gfs2_sbd *sdp)
spin_lock(&sdp->sd_ail_lock);
- if (list_empty(&sdp->sd_ail1_list)) {
- tail = sdp->sd_log_head;
- } else {
- tr = list_entry(sdp->sd_ail1_list.prev, struct gfs2_trans,
- tr_list);
- tail = tr->tr_first;
- }
+ tr = list_last_entry_or_null(&sdp->sd_ail1_list, struct gfs2_trans,
+ tr_list);
+ tail = tr ? tr->tr_first : sdp->sd_log_head;
spin_unlock(&sdp->sd_ail_lock);
--
1.8.3.2
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: jfs-discussion@lists.sourceforge.net, jiri@resnulli.us,
gregkh@linuxfoundation.org, oleg@redhat.com,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
akpm@linux-foundation.org
Subject: [PATCH 3/6] gfs2: simplify current_tail() via list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:32:52 +0800 [thread overview]
Message-ID: <5285A3F4.4040000@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Simplify the code in current_tail() via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/gfs2/log.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 610613f..555f767 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -441,13 +441,9 @@ static unsigned int current_tail(struct gfs2_sbd *sdp)
spin_lock(&sdp->sd_ail_lock);
- if (list_empty(&sdp->sd_ail1_list)) {
- tail = sdp->sd_log_head;
- } else {
- tr = list_entry(sdp->sd_ail1_list.prev, struct gfs2_trans,
- tr_list);
- tail = tr->tr_first;
- }
+ tr = list_last_entry_or_null(&sdp->sd_ail1_list, struct gfs2_trans,
+ tr_list);
+ tail = tr ? tr->tr_first : sdp->sd_log_head;
spin_unlock(&sdp->sd_ail_lock);
--
1.8.3.2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, "xfs@oss.sgi.com" <xfs@oss.sgi.com>,
cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
jfs-discussion@lists.sourceforge.net, oleg@redhat.com,
jiri@resnulli.us, gregkh@linuxfoundation.org
Subject: [PATCH 3/6] gfs2: simplify current_tail() via list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:32:52 +0800 [thread overview]
Message-ID: <5285A3F4.4040000@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Simplify the code in current_tail() via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/gfs2/log.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 610613f..555f767 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -441,13 +441,9 @@ static unsigned int current_tail(struct gfs2_sbd *sdp)
spin_lock(&sdp->sd_ail_lock);
- if (list_empty(&sdp->sd_ail1_list)) {
- tail = sdp->sd_log_head;
- } else {
- tr = list_entry(sdp->sd_ail1_list.prev, struct gfs2_trans,
- tr_list);
- tail = tr->tr_first;
- }
+ tr = list_last_entry_or_null(&sdp->sd_ail1_list, struct gfs2_trans,
+ tr_list);
+ tail = tr ? tr->tr_first : sdp->sd_log_head;
spin_unlock(&sdp->sd_ail_lock);
--
1.8.3.2
next reply other threads:[~2013-11-15 4:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 4:32 Jeff Liu [this message]
2013-11-15 4:32 ` [PATCH 3/6] gfs2: simplify current_tail() via list_last_entry_or_null() Jeff Liu
2013-11-15 4:32 ` Jeff Liu
2013-11-15 4:32 ` Jeff Liu
2013-11-15 16:39 ` [Cluster-devel] " Oleg Nesterov
2013-11-15 16:39 ` Oleg Nesterov
2013-11-15 16:39 ` Oleg Nesterov
2013-11-15 16:39 ` Oleg Nesterov
2013-11-15 17:12 ` [Cluster-devel] introduce list_get_first/last (Was: [PATCH 3/6] gfs2: simplify current_tail() via list_last_entry_or_null()) Oleg Nesterov
2013-11-15 17:12 ` Oleg Nesterov
2013-11-15 17:12 ` Oleg Nesterov
2013-11-15 17:12 ` Oleg Nesterov
2013-11-18 5:41 ` [Cluster-devel] " Jeff Liu
2013-11-18 5:41 ` Jeff Liu
2013-11-18 5:41 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5285A3F4.4040000@oracle.com \
--to=jeff.liu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.