From: Jeff Liu <jeff.liu@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:34:44 +0800 [thread overview]
Message-ID: <5285A464.1070904@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Simplify the code in lmNextPage via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/jfs/jfs_logmgr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 360d27c..7b565d0 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -591,10 +591,7 @@ static int lmNextPage(struct jfs_log * log)
* write or queue the full page at the tail of write queue
*/
/* get the tail tblk on commit queue */
- if (list_empty(&log->cqueue))
- tblk = NULL;
- else
- tblk = list_entry(log->cqueue.prev, struct tblock, cqueue);
+ tblk = list_last_entry_or_null(&log->cqueue, struct tblock, cqueue);
/* every tblk who has COMMIT record on the current page,
* and has not been committed, must be on commit queue
--
1.8.3.2
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: jfs-discussion@lists.sourceforge.net, jiri@resnulli.us,
gregkh@linuxfoundation.org, oleg@redhat.com,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
akpm@linux-foundation.org
Subject: [PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:34:44 +0800 [thread overview]
Message-ID: <5285A464.1070904@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Simplify the code in lmNextPage via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/jfs/jfs_logmgr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 360d27c..7b565d0 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -591,10 +591,7 @@ static int lmNextPage(struct jfs_log * log)
* write or queue the full page at the tail of write queue
*/
/* get the tail tblk on commit queue */
- if (list_empty(&log->cqueue))
- tblk = NULL;
- else
- tblk = list_entry(log->cqueue.prev, struct tblock, cqueue);
+ tblk = list_last_entry_or_null(&log->cqueue, struct tblock, cqueue);
/* every tblk who has COMMIT record on the current page,
* and has not been committed, must be on commit queue
--
1.8.3.2
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: jfs-discussion@lists.sourceforge.net, jiri@resnulli.us,
gregkh@linuxfoundation.org, oleg@redhat.com,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
akpm@linux-foundation.org
Subject: [PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:34:44 +0800 [thread overview]
Message-ID: <5285A464.1070904@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Simplify the code in lmNextPage via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/jfs/jfs_logmgr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 360d27c..7b565d0 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -591,10 +591,7 @@ static int lmNextPage(struct jfs_log * log)
* write or queue the full page at the tail of write queue
*/
/* get the tail tblk on commit queue */
- if (list_empty(&log->cqueue))
- tblk = NULL;
- else
- tblk = list_entry(log->cqueue.prev, struct tblock, cqueue);
+ tblk = list_last_entry_or_null(&log->cqueue, struct tblock, cqueue);
/* every tblk who has COMMIT record on the current page,
* and has not been committed, must be on commit queue
--
1.8.3.2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, "xfs@oss.sgi.com" <xfs@oss.sgi.com>,
cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
jfs-discussion@lists.sourceforge.net, oleg@redhat.com,
jiri@resnulli.us, gregkh@linuxfoundation.org
Subject: [PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:34:44 +0800 [thread overview]
Message-ID: <5285A464.1070904@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Simplify the code in lmNextPage via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/jfs/jfs_logmgr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 360d27c..7b565d0 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -591,10 +591,7 @@ static int lmNextPage(struct jfs_log * log)
* write or queue the full page at the tail of write queue
*/
/* get the tail tblk on commit queue */
- if (list_empty(&log->cqueue))
- tblk = NULL;
- else
- tblk = list_entry(log->cqueue.prev, struct tblock, cqueue);
+ tblk = list_last_entry_or_null(&log->cqueue, struct tblock, cqueue);
/* every tblk who has COMMIT record on the current page,
* and has not been committed, must be on commit queue
--
1.8.3.2
next reply other threads:[~2013-11-15 4:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 4:34 Jeff Liu [this message]
2013-11-15 4:34 ` [PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null() Jeff Liu
2013-11-15 4:34 ` Jeff Liu
2013-11-15 4:34 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5285A464.1070904@oracle.com \
--to=jeff.liu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.