From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>,
kvm-devel <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>
Subject: Re: [RFC] target-arm: Provide mechanism for getting KVM constants even if not CONFIG_KVM
Date: Fri, 15 Nov 2013 12:33:08 +0100 [thread overview]
Message-ID: <52860674.4040904@redhat.com> (raw)
In-Reply-To: <CAFEAcA8wiXPzOOqx-denOeCZ06z1_-RYkU3m+s=m=oZQ_WU-Dg@mail.gmail.com>
Il 15/11/2013 12:26, Peter Maydell ha scritto:
>> > It's okay. There are indeed advantages to putting this together with
>> > the definitions, instead of splitting it between target-arm/cpu.h and
>> > target-arm/kvm.c.
> Cool. I just wanted to check I wasn't missing some
> clever approach to this that might have avoided the
> need to duplicate all the definitions.
If you call your constants KVM_FOO, the compiler should not warn for a
redefinition with the exact same content. But I find that more gross
than clever...
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Gleb Natapov <gleb@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
kvm-devel <kvm@vger.kernel.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [RFC] target-arm: Provide mechanism for getting KVM constants even if not CONFIG_KVM
Date: Fri, 15 Nov 2013 12:33:08 +0100 [thread overview]
Message-ID: <52860674.4040904@redhat.com> (raw)
In-Reply-To: <CAFEAcA8wiXPzOOqx-denOeCZ06z1_-RYkU3m+s=m=oZQ_WU-Dg@mail.gmail.com>
Il 15/11/2013 12:26, Peter Maydell ha scritto:
>> > It's okay. There are indeed advantages to putting this together with
>> > the definitions, instead of splitting it between target-arm/cpu.h and
>> > target-arm/kvm.c.
> Cool. I just wanted to check I wasn't missing some
> clever approach to this that might have avoided the
> need to duplicate all the definitions.
If you call your constants KVM_FOO, the compiler should not warn for a
redefinition with the exact same content. But I find that more gross
than clever...
Paolo
next prev parent reply other threads:[~2013-11-15 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 19:07 [RFC] target-arm: Provide mechanism for getting KVM constants even if not CONFIG_KVM Peter Maydell
2013-11-14 19:07 ` [Qemu-devel] " Peter Maydell
2013-11-15 10:54 ` Paolo Bonzini
2013-11-15 10:54 ` [Qemu-devel] " Paolo Bonzini
2013-11-15 11:26 ` Peter Maydell
2013-11-15 11:26 ` [Qemu-devel] " Peter Maydell
2013-11-15 11:33 ` Paolo Bonzini [this message]
2013-11-15 11:33 ` Paolo Bonzini
2013-11-15 11:58 ` Peter Maydell
2013-11-15 11:58 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52860674.4040904@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.