* [PATCH] staging: dwc2: do not clear pending interrupts twice
@ 2013-11-15 10:39 Julien DELACOU
2013-11-15 10:55 ` Dan Carpenter
2013-11-15 19:59 ` Paul Zimmerman
0 siblings, 2 replies; 4+ messages in thread
From: Julien DELACOU @ 2013-11-15 10:39 UTC (permalink / raw)
To: Paul Zimmerman, Matthijs Kooijman, Greg Kroah-Hartman,
Grant Likely
Cc: linux-kernel, linux-usb, devel, Julien Delacou
Pending interrupts clearing is done in dwc2_enable_common_interrupts
so we don't need to do it twice.
Signed-off-by: Julien Delacou <julien.delacou@st.com>
---
drivers/staging/dwc2/core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
index c8ff668..8374ec3 100644
--- a/drivers/staging/dwc2/core.c
+++ b/drivers/staging/dwc2/core.c
@@ -533,9 +533,6 @@ void dwc2_enable_host_interrupts(struct dwc2_hsotg *hsotg)
writel(0, hsotg->regs + GINTMSK);
writel(0, hsotg->regs + HAINTMSK);
- /* Clear any pending interrupts */
- writel(0xffffffff, hsotg->regs + GINTSTS);
-
/* Enable the common interrupts */
dwc2_enable_common_interrupts(hsotg);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: dwc2: do not clear pending interrupts twice
2013-11-15 10:39 [PATCH] staging: dwc2: do not clear pending interrupts twice Julien DELACOU
@ 2013-11-15 10:55 ` Dan Carpenter
2013-11-15 12:28 ` Julien DELACOU
2013-11-15 19:59 ` Paul Zimmerman
1 sibling, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2013-11-15 10:55 UTC (permalink / raw)
To: Julien DELACOU
Cc: Paul Zimmerman, Matthijs Kooijman, Greg Kroah-Hartman,
Grant Likely, devel, linux-usb, linux-kernel
On Fri, Nov 15, 2013 at 11:39:38AM +0100, Julien DELACOU wrote:
> Pending interrupts clearing is done in dwc2_enable_common_interrupts
> so we don't need to do it twice.
>
Are there any user visible effects to this bug? How did you spot it?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: dwc2: do not clear pending interrupts twice
2013-11-15 10:55 ` Dan Carpenter
@ 2013-11-15 12:28 ` Julien DELACOU
0 siblings, 0 replies; 4+ messages in thread
From: Julien DELACOU @ 2013-11-15 12:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: Paul Zimmerman, Matthijs Kooijman, Greg Kroah-Hartman,
Grant Likely, devel@driverdev.osuosl.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
On 11/15/2013 11:55 AM, Dan Carpenter wrote:
> On Fri, Nov 15, 2013 at 11:39:38AM +0100, Julien DELACOU wrote:
>> Pending interrupts clearing is done in dwc2_enable_common_interrupts
>> so we don't need to do it twice.
>>
> Are there any user visible effects to this bug? How did you spot it?
>
> regards,
> dan carpenter
>
>
Honestly, there is not. I am working on another issue using that
controller and noticed it during reviewing the global behavior.
Best regards,
Julien
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] staging: dwc2: do not clear pending interrupts twice
2013-11-15 10:39 [PATCH] staging: dwc2: do not clear pending interrupts twice Julien DELACOU
2013-11-15 10:55 ` Dan Carpenter
@ 2013-11-15 19:59 ` Paul Zimmerman
1 sibling, 0 replies; 4+ messages in thread
From: Paul Zimmerman @ 2013-11-15 19:59 UTC (permalink / raw)
To: Julien DELACOU, Matthijs Kooijman, Greg Kroah-Hartman,
Grant Likely
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
devel@driverdev.osuosl.org
> From: Julien DELACOU [mailto:julien.delacou@st.com]
> Sent: Friday, November 15, 2013 2:40 AM
>
> Pending interrupts clearing is done in dwc2_enable_common_interrupts
> so we don't need to do it twice.
>
> Signed-off-by: Julien Delacou <julien.delacou@st.com>
> ---
> drivers/staging/dwc2/core.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
> index c8ff668..8374ec3 100644
> --- a/drivers/staging/dwc2/core.c
> +++ b/drivers/staging/dwc2/core.c
> @@ -533,9 +533,6 @@ void dwc2_enable_host_interrupts(struct dwc2_hsotg *hsotg)
> writel(0, hsotg->regs + GINTMSK);
> writel(0, hsotg->regs + HAINTMSK);
>
> - /* Clear any pending interrupts */
> - writel(0xffffffff, hsotg->regs + GINTSTS);
> -
> /* Enable the common interrupts */
> dwc2_enable_common_interrupts(hsotg);
>
> --
Acked-by: Paul Zimmerman <paulz@synopsys.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-15 19:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-15 10:39 [PATCH] staging: dwc2: do not clear pending interrupts twice Julien DELACOU
2013-11-15 10:55 ` Dan Carpenter
2013-11-15 12:28 ` Julien DELACOU
2013-11-15 19:59 ` Paul Zimmerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.