* [PATCH] ASoC: tegra: use clk_disable_unprepare instead of clk_disable
@ 2013-11-15 9:53 Wei Yongjun
[not found] ` <CAPgLHd84PK+6b0OfnRqBppvBk9i3Xy=ZEiPQO8ZCPz+NW9g4Uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-15 17:44 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2013-11-15 9:53 UTC (permalink / raw)
To: swarren-3lzwWm7+Weoh9ZMKESR00Q, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w,
broonie-DgEjT+Ai2ygdnm+yROfE0A, perex-/Fr2/VpizcU,
tiwai-l3A5Bk7waGM, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
grant.likely-QSEj5FYQhm4dnm+yROfE0A,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ
Cc: yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
clk_prepare_enable() is used so clk_disable_unprepare() should be
used instead of clk_disable() in the error handling path.
Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
---
sound/soc/tegra/tegra30_ahub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c
index 3115433..63f65d9 100644
--- a/sound/soc/tegra/tegra30_ahub.c
+++ b/sound/soc/tegra/tegra30_ahub.c
@@ -84,7 +84,7 @@ static int tegra30_ahub_runtime_resume(struct device *dev)
ret = clk_prepare_enable(ahub->clk_apbif);
if (ret) {
dev_err(dev, "clk_enable apbif failed: %d\n", ret);
- clk_disable(ahub->clk_d_audio);
+ clk_disable_unprepare(ahub->clk_d_audio);
return ret;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: tegra: use clk_disable_unprepare instead of clk_disable
[not found] ` <CAPgLHd84PK+6b0OfnRqBppvBk9i3Xy=ZEiPQO8ZCPz+NW9g4Uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-11-15 16:39 ` Stephen Warren
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2013-11-15 16:39 UTC (permalink / raw)
To: Wei Yongjun, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w,
broonie-DgEjT+Ai2ygdnm+yROfE0A, perex-/Fr2/VpizcU,
tiwai-l3A5Bk7waGM, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
grant.likely-QSEj5FYQhm4dnm+yROfE0A,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ
Cc: yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On 11/15/2013 02:53 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
>
> clk_prepare_enable() is used so clk_disable_unprepare() should be
> used instead of clk_disable() in the error handling path.
Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: tegra: use clk_disable_unprepare instead of clk_disable
2013-11-15 9:53 [PATCH] ASoC: tegra: use clk_disable_unprepare instead of clk_disable Wei Yongjun
[not found] ` <CAPgLHd84PK+6b0OfnRqBppvBk9i3Xy=ZEiPQO8ZCPz+NW9g4Uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-11-15 17:44 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-11-15 17:44 UTC (permalink / raw)
To: Wei Yongjun
Cc: alsa-devel, swarren, tiwai, lgirdwood, rob.herring, linux-tegra,
yongjun_wei, thierry.reding, grant.likely
[-- Attachment #1.1: Type: text/plain, Size: 269 bytes --]
On Fri, Nov 15, 2013 at 05:53:45PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> clk_prepare_enable() is used so clk_disable_unprepare() should be
> used instead of clk_disable() in the error handling path.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-16 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-15 9:53 [PATCH] ASoC: tegra: use clk_disable_unprepare instead of clk_disable Wei Yongjun
[not found] ` <CAPgLHd84PK+6b0OfnRqBppvBk9i3Xy=ZEiPQO8ZCPz+NW9g4Uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-15 16:39 ` Stephen Warren
2013-11-15 17:44 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.