Re: [Qemu-trivial] [PATCH] hw/i386/Makefile.obj: use $(PYTHON) to run .py scripts consistently

[Stefan Weil <sw@weilnetz.de>]

Am 16.11.2013 11:14, schrieb Michael Tokarev:
> $(PYTHON) is a Make variable which is set by configure.
> In all other places over the tree, .py files are run from
> Makefiles using this variable, except of a single leftover
> in hw/i386/Makefile.obj (and a nearby place in there uses
> $(PYTHON) correctly).  Fix this leftover too.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Luigi Rizzo <rizzo@iet.unipi.it>
> Cc: Stefan Weil <sw@weilnetz.de>
>
> --
> mjt: I want to apply this to trivial-patches for-1.7
> ---
>  hw/i386/Makefile.objs |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> index 185aacb..09ac433 100644
> --- a/hw/i386/Makefile.objs
> +++ b/hw/i386/Makefile.objs
> @@ -20,7 +20,7 @@ hw/i386/%.hex: $(SRC_PATH)/hw/i386/%.dsl $(SRC_PATH)/scripts/acpi_extract_prepro
>  	$(call quiet-command, cpp -P $< -o $*.dsl.i.orig, "  CPP $(TARGET_DIR)$*.dsl.i.orig")
>  	$(call quiet-command, $(PYTHON) $(SRC_PATH)/scripts/acpi_extract_preprocess.py $*.dsl.i.orig > $*.dsl.i, "  ACPI_PREPROCESS $(TARGET_DIR)$*.dsl.i")
>  	$(call quiet-command, $(IASL) $(call iasl-option,$(IASL),-Pn,) -vs -l -tc -p $* $*.dsl.i $(if $(V), , > /dev/null) 2>&1 ,"  IASL $(TARGET_DIR)$*.dsl.i")
> -	$(call quiet-command, $(SRC_PATH)/scripts/acpi_extract.py $*.lst > $*.off, "  ACPI_EXTRACT $(TARGET_DIR)$*.off")
> +	$(call quiet-command, $(PYTHON) $(SRC_PATH)/scripts/acpi_extract.py $*.lst > $*.off, "  ACPI_EXTRACT $(TARGET_DIR)$*.off")
>  	$(call quiet-command, cat $*.off > $@, "  CAT $(TARGET_DIR)$@")
>  else
>  #IASL Not present. Restore pre-generated hex files.


Reviewed-by: Stefan Weil <sw@weilnetz.de>

Yes, this is a bug fix which should be included in QEMU 1.7.

Regards,
Stefan