All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: omap3: Enable clocks for peripherals only if they are used
Date: Tue, 19 Nov 2013 10:24:15 +0200	[thread overview]
Message-ID: <528B202F.3000607@compulab.co.il> (raw)
In-Reply-To: <20131118141047.GA4145@panicking>

Hi Michael,

On 11/18/13 16:10, Michael Trimarchi wrote:
> Enable clocks for the peripherals only if they are used
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
>  arch/arm/cpu/armv7/omap3/clock.c        | 2 --
>  arch/arm/include/asm/arch-omap3/clock.h | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/omap3/clock.c b/arch/arm/cpu/armv7/omap3/clock.c
> index 14fc7e8..1bc27bd 100644
> --- a/arch/arm/cpu/armv7/omap3/clock.c
> +++ b/arch/arm/cpu/armv7/omap3/clock.c
> @@ -730,8 +730,6 @@ void per_clocks_enable(void)
>  		sr32(&prcm_base->fclken_cam, 0, 32, FCK_CAM_ON);
>  		sr32(&prcm_base->iclken_cam, 0, 32, ICK_CAM_ON);
>  	}
> -	sr32(&prcm_base->fclken_per, 0, 32, FCK_PER_ON);
> -	sr32(&prcm_base->iclken_per, 0, 32, ICK_PER_ON);

Hmmm...
Am I missing something or is this change breaks boards that
currently rely on the peripheral clocks being enabled here?

>  
>  	sdelay(1000);
>  }
> diff --git a/arch/arm/include/asm/arch-omap3/clock.h b/arch/arm/include/asm/arch-omap3/clock.h
> index be669c1..1912cc9 100644
> --- a/arch/arm/include/asm/arch-omap3/clock.h
> +++ b/arch/arm/include/asm/arch-omap3/clock.h
> @@ -27,8 +27,6 @@
>  #define ICK_DSS_ON	0x00000001
>  #define FCK_CAM_ON	0x00000001
>  #define ICK_CAM_ON	0x00000001
> -#define FCK_PER_ON	0x0003ffff
> -#define ICK_PER_ON	0x0003ffff
>  
>  /* Used to index into DPLL parameter tables */
>  typedef struct {
> 

-- 
Regards,
Igor.

  reply	other threads:[~2013-11-19  8:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 14:10 [U-Boot] [PATCH] arm: omap3: Enable clocks for peripherals only if they are used Michael Trimarchi
2013-11-19  8:24 ` Igor Grinberg [this message]
2013-11-19  8:49   ` Michael Trimarchi
2013-11-19  8:59     ` Michael Trimarchi
2013-11-19 11:10       ` Igor Grinberg
2013-11-19 11:56         ` Michael Trimarchi
2013-11-20 16:19           ` Tom Rini
2013-11-20 20:07             ` Michael Trimarchi
2013-11-21  9:26               ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528B202F.3000607@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.