From: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] spi/qspi: cleanup qspi remova path and error check.
Date: Tue, 19 Nov 2013 17:20:57 +0530 [thread overview]
Message-ID: <528B50A1.1080609@ti.com> (raw)
In-Reply-To: <20131119113125.GZ2674-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Tuesday 19 November 2013 05:01 PM, Mark Brown wrote:
> On Tue, Nov 19, 2013 at 04:28:23PM +0530, Sourav Poddar wrote:
>> There is a bug in qspi removal path, as a result of which
>> qspi cannot be removed when used as a module. The patch
>> solves the bug and qspi can be removed cleanly.
> What is the bug? The important bit of information is what's actually
> being changed.
>
pm_runtime api is not used to properly disable the PM part.
spi_unregister_master(qspi->master) shows a NULL pointer dereference.
>> Also align the runtime error path check through out the code.
Ok.
> This should be split out.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-11-19 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 10:58 [PATCH] spi/qspi: cleanup qspi remova path and error check Sourav Poddar
[not found] ` <1384858703-30938-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-11-19 11:00 ` Sourav Poddar
2013-11-19 11:31 ` Mark Brown
[not found] ` <20131119113125.GZ2674-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-19 11:50 ` Sourav Poddar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528B50A1.1080609@ti.com \
--to=sourav.poddar-l0cymroini0@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.