Re: [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Vlad Yasevich <vyasevich@gmail.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo
Date: Tue, 19 Nov 2013 15:25:45 +0000	[thread overview]
Message-ID: <528B82F9.6000708@gmail.com> (raw)
In-Reply-To: <1384829247-8624-3-git-send-email-wangweidong1@huawei.com>

On 11/19/2013 09:23 AM, Eric Dumazet wrote:
> On Tue, 2013-11-19 at 12:35 +0100, Daniel Borkmann wrote:
>> On 11/19/2013 05:00 AM, Eric Dumazet wrote:
>>> On Mon, 2013-11-18 at 19:58 -0800, Eric Dumazet wrote:
>>>
>>>> But sctp is not tcp ;)
>>>>
>>>> sctp_copy_sock() is doing some clever/partial copy of the socket, so
>>>> please fix it ;)
>>>>
>>>> No idea why it's not doing the normal copy of the socket.
>>>
>>> BTW, not doing the full copy means for example that SO_MAX_PACING_RATE
>>> is broken for SCTP.
>>
>> Yep, indeed. Looking into it ...
> 
> It might be the time to finally use inet_csk_clone_lock() in SCTP.
> 
> 

I can see sk_clone_lock() since SCTP doesn't use icsk sockets.  Need
to study the code a bit.

-vlad

WARNING: multiple messages have this Message-ID (diff)

From: Vlad Yasevich <vyasevich@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
	Daniel Borkmann <dborkman@redhat.com>
Cc: wangweidong <wangweidong1@huawei.com>,
	davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru,
	jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
	nhorman@tuxdriver.com, dccp@vger.kernel.org,
	netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	dingtianhong@huawei.com
Subject: Re: [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo
Date: Tue, 19 Nov 2013 15:25:45 +0000	[thread overview]
Message-ID: <528B82F9.6000708@gmail.com> (raw)
In-Reply-To: <1384871001.8604.103.camel@edumazet-glaptop2.roam.corp.google.com>

On 11/19/2013 09:23 AM, Eric Dumazet wrote:
> On Tue, 2013-11-19 at 12:35 +0100, Daniel Borkmann wrote:
>> On 11/19/2013 05:00 AM, Eric Dumazet wrote:
>>> On Mon, 2013-11-18 at 19:58 -0800, Eric Dumazet wrote:
>>>
>>>> But sctp is not tcp ;)
>>>>
>>>> sctp_copy_sock() is doing some clever/partial copy of the socket, so
>>>> please fix it ;)
>>>>
>>>> No idea why it's not doing the normal copy of the socket.
>>>
>>> BTW, not doing the full copy means for example that SO_MAX_PACING_RATE
>>> is broken for SCTP.
>>
>> Yep, indeed. Looking into it ...
> 
> It might be the time to finally use inet_csk_clone_lock() in SCTP.
> 
> 

I can see sk_clone_lock() since SCTP doesn't use icsk sockets.  Need
to study the code a bit.

-vlad

WARNING: multiple messages have this Message-ID (diff)

From: Vlad Yasevich <vyasevich@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
	Daniel Borkmann <dborkman@redhat.com>
Cc: wangweidong <wangweidong1@huawei.com>,
	davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru,
	jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
	nhorman@tuxdriver.com, dccp@vger.kernel.org,
	netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	dingtianhong@huawei.com
Subject: Re: [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo
Date: Tue, 19 Nov 2013 10:25:45 -0500	[thread overview]
Message-ID: <528B82F9.6000708@gmail.com> (raw)
In-Reply-To: <1384871001.8604.103.camel@edumazet-glaptop2.roam.corp.google.com>

On 11/19/2013 09:23 AM, Eric Dumazet wrote:
> On Tue, 2013-11-19 at 12:35 +0100, Daniel Borkmann wrote:
>> On 11/19/2013 05:00 AM, Eric Dumazet wrote:
>>> On Mon, 2013-11-18 at 19:58 -0800, Eric Dumazet wrote:
>>>
>>>> But sctp is not tcp ;)
>>>>
>>>> sctp_copy_sock() is doing some clever/partial copy of the socket, so
>>>> please fix it ;)
>>>>
>>>> No idea why it's not doing the normal copy of the socket.
>>>
>>> BTW, not doing the full copy means for example that SO_MAX_PACING_RATE
>>> is broken for SCTP.
>>
>> Yep, indeed. Looking into it ...
> 
> It might be the time to finally use inet_csk_clone_lock() in SCTP.
> 
> 

I can see sk_clone_lock() since SCTP doesn't use icsk sockets.  Need
to study the code a bit.

-vlad

next prev parent reply	other threads:[~2013-11-19 15:25 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19  2:47 [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo Wang Weidong
2013-11-19  2:47 ` Wang Weidong
2013-11-19  2:47 ` Wang Weidong
2013-11-19  3:14 ` Hannes Frederic Sowa
2013-11-19  3:14   ` Hannes Frederic Sowa
2013-11-19  3:14   ` Hannes Frederic Sowa
2013-11-19  3:32 ` wangweidong
2013-11-19  3:32   ` wangweidong
2013-11-19  3:32   ` wangweidong
2013-11-19  3:55 ` Eric Dumazet
2013-11-19  3:55   ` Eric Dumazet
2013-11-19  3:55   ` Eric Dumazet
2013-11-19  3:58 ` Eric Dumazet
2013-11-19  3:58   ` Eric Dumazet
2013-11-19  3:58   ` Eric Dumazet
2013-11-19  4:00 ` Eric Dumazet
2013-11-19  4:00   ` Eric Dumazet
2013-11-19  4:00   ` Eric Dumazet
2013-11-19  4:38 ` wangweidong
2013-11-19  4:38   ` wangweidong
2013-11-19  4:38   ` wangweidong
2013-11-19  4:44 ` wangweidong
2013-11-19  4:44   ` wangweidong
2013-11-19  4:44   ` wangweidong
2013-11-19 11:04 ` Daniel Borkmann
2013-11-19 11:04   ` Daniel Borkmann
2013-11-19 11:04   ` Daniel Borkmann
2013-11-19 11:09 ` wangweidong
2013-11-19 11:09   ` wangweidong
2013-11-19 11:09   ` wangweidong
2013-11-19 11:35 ` Daniel Borkmann
2013-11-19 11:35   ` Daniel Borkmann
2013-11-19 11:35   ` Daniel Borkmann
2013-11-19 14:23 ` Eric Dumazet
2013-11-19 14:23   ` Eric Dumazet
2013-11-19 14:23   ` Eric Dumazet
2013-11-19 14:26 ` Daniel Borkmann
2013-11-19 14:26   ` Daniel Borkmann
2013-11-19 14:26   ` Daniel Borkmann
2013-11-19 15:25 ` Vlad Yasevich [this message]
2013-11-19 15:25   ` Vlad Yasevich
2013-11-19 15:25   ` Vlad Yasevich
  -- strict thread matches above, loose matches on Subject: below --
2013-11-19  2:47 [PATCH 1/2] ipv6: add helper function for copy addrs from old sock Wang Weidong
2013-11-19  2:47 ` Wang Weidong
2013-11-19  2:47 ` Wang Weidong
2013-11-19  2:47 [PATCH 0/2] ipv6: fix the missing copies when memcpy ipv6_pinfo Wang Weidong
2013-11-19  2:47 ` Wang Weidong
2013-11-19  2:47 ` Wang Weidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528B82F9.6000708@gmail.com \
    --to=vyasevich@gmail.com \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.