All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-trivial] [PATCH for 1.7 v2] qga: Fix compiler warnings (missing format attribute, wrong format strings)
Date: Wed, 20 Nov 2013 15:49:33 +0400	[thread overview]
Message-ID: <528CA1CD.2020803@msgid.tls.msk.ru> (raw)
In-Reply-To: <1384712392-10458-1-git-send-email-sw@weilnetz.de>

17.11.2013 22:19, Stefan Weil wrote:
> gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
> 
>   CC    qga/commands.o
> qga/commands.c: In function ‘slog’:
> qga/commands.c:28:5: error:
>  function might be possible candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>      g_logv("syslog", G_LOG_LEVEL_INFO, fmt, ap);
>      ^
> 
> gcc 4.8.2 reports this warning when slog is declared with the
> gnu_printf format attribute:
> 
> qga/commands-posix.c: In function ‘qmp_guest_file_open’:
> qga/commands-posix.c:404:5: warning:
>  format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘int64_t’ [-Wformat=]
>      slog("guest-file-open, handle: %d", handle);
>      ^
> 
> On 32 bit hosts there are three more warnings which are also fixed here.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> v2: Fix three more wrong format strings for 32 bit hosts.

Thanks, applied to the trivial-patches queue.

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7 v2] qga: Fix compiler warnings (missing format attribute, wrong format strings)
Date: Wed, 20 Nov 2013 15:49:33 +0400	[thread overview]
Message-ID: <528CA1CD.2020803@msgid.tls.msk.ru> (raw)
In-Reply-To: <1384712392-10458-1-git-send-email-sw@weilnetz.de>

17.11.2013 22:19, Stefan Weil wrote:
> gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
> 
>   CC    qga/commands.o
> qga/commands.c: In function ‘slog’:
> qga/commands.c:28:5: error:
>  function might be possible candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>      g_logv("syslog", G_LOG_LEVEL_INFO, fmt, ap);
>      ^
> 
> gcc 4.8.2 reports this warning when slog is declared with the
> gnu_printf format attribute:
> 
> qga/commands-posix.c: In function ‘qmp_guest_file_open’:
> qga/commands-posix.c:404:5: warning:
>  format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘int64_t’ [-Wformat=]
>      slog("guest-file-open, handle: %d", handle);
>      ^
> 
> On 32 bit hosts there are three more warnings which are also fixed here.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> v2: Fix three more wrong format strings for 32 bit hosts.

Thanks, applied to the trivial-patches queue.

/mjt

  parent reply	other threads:[~2013-11-20 11:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-17 18:19 [Qemu-trivial] [PATCH for 1.7 v2] qga: Fix compiler warnings (missing format attribute, wrong format strings) Stefan Weil
2013-11-17 18:19 ` [Qemu-devel] " Stefan Weil
2013-11-18 21:32 ` [Qemu-trivial] " Stefan Weil
2013-11-18 21:32   ` [Qemu-devel] " Stefan Weil
2013-11-20 11:49 ` Michael Tokarev [this message]
2013-11-20 11:49   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528CA1CD.2020803@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=aliguori@amazon.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.