Re: [PATCH 06/16] xen: arm: early logging of command line

[Julien Grall <julien.grall@linaro.org>]

On 11/20/2013 02:48 PM, Ian Campbell wrote:
> Helpful for diagnosis of bad console= parameters.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Thanks, I wanted to create a similar patch ! :)

I think it can be apply now without the other patches.

Acked-by: Julien Grall <julien.grall@linaro.org>

> ---
>  xen/arch/arm/setup.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 49e1b5c..d252131 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -597,6 +597,7 @@ void __init start_xen(unsigned long boot_phys_offset,
>  {
>      size_t fdt_size;
>      int cpus, i;
> +    const char *cmdline;
>  
>      setup_cache();
>  
> @@ -610,7 +611,9 @@ void __init start_xen(unsigned long boot_phys_offset,
>          + (fdt_paddr & ((1 << SECOND_SHIFT) - 1));
>      fdt_size = device_tree_early_init(device_tree_flattened, fdt_paddr);
>  
> -    cmdline_parse(device_tree_bootargs(device_tree_flattened));
> +    cmdline = device_tree_bootargs(device_tree_flattened);
> +    early_printk("Command line: %s\n", cmdline);
> +    cmdline_parse(cmdline);
>  
>      setup_pagetables(boot_phys_offset, get_xen_paddr());
>      setup_mm(fdt_paddr, fdt_size);
> 


-- 
Julien Grall