Re: [PATCH 16/16] HACK: xen: arm: map PCI controller ranges region MMIOs to dom0.

[Julien Grall <julien.grall@linaro.org>]

On 11/21/2013 02:57 PM, Ian Campbell wrote:
> On Thu, 2013-11-21 at 14:32 +0000, Julien Grall wrote:
>>
>> On 11/20/2013 02:48 PM, Ian Campbell wrote:
>>> The ranges property of a node with device_type = "pci" is defined in ePAPR
>>> 2.3.8. Map the appropriate MMIO regions through to dom0.
>>>
>>> This is a hack/PoC since it actually crashes for some reason. Hence it
>>> contains a hacked in hardcoded list suitable for Xgene while I figure this
>>> out.
>>>
>>> This should also eventually handle the interrupt-map and (ePAPR 2.4.3.1) and
>>> possibly dma-ranges (ePAPR 2.3.9) and msi-ranges (unspeciifed?) too.
>>
>>
>> For pci ranges, you can add a new bus in dt_bues. So you won't need
>> specific code in domain_build.c and we will be able to use it later.
>> You can take a look to linux/drivers/of/address.c
>
> Won't we still need to handle the resulting extra MMIO addresses which
> are not part of the reg region?

Which MMIO addresses are you talking about? I though all the ranges are 
described by "reg"?

If the modification is too hard to implement for Xen 4.4, you can 
implement specific_mapping callback for APM.

>
>> Mapping interrupt should be OK. I don't see any reason that will fail
>> with the current code because IRQ are all under the GIC controller.
>
> We need to parse interrupt-map because the child interrupts are not
> listed in the regular interrupts property.

Right, I didn't notice that the interrupt-map is difference for pci.

-- 
Julien Grall