From: Stefan Weil <sw@weilnetz.de>
To: Gleb Natapov <gleb@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [PATCH for 1.7] kvm: Fix uninitialized cpuid_data
Date: Wed, 20 Nov 2013 19:54:33 +0100 [thread overview]
Message-ID: <528D0569.3080308@weilnetz.de> (raw)
In-Reply-To: <20131107111516.GB7513@redhat.com>
Am 07.11.2013 12:15, schrieb Gleb Natapov:
> On Wed, Nov 06, 2013 at 10:35:27PM +0100, Stefan Weil wrote:
>> This error was reported by valgrind when running qemu-system-x86_64
>> with kvm:
>>
>> ==975== Conditional jump or move depends on uninitialised value(s)
>> ==975== at 0x521C38: cpuid_find_entry (kvm.c:176)
>> ==975== by 0x5235BA: kvm_arch_init_vcpu (kvm.c:686)
>> ==975== by 0x4D5175: kvm_init_vcpu (kvm-all.c:267)
>> ==975== by 0x45035B: qemu_kvm_cpu_thread_fn (cpus.c:858)
>> ==975== by 0xD361E0D: start_thread (pthread_create.c:311)
>> ==975== by 0xD65E9EC: clone (clone.S:113)
>> ==975== Uninitialised value was created by a stack allocation
>> ==975== at 0x5226E4: kvm_arch_init_vcpu (kvm.c:446)
>>
>> Instead of adding more memset calls for parts of cpuid_data, the existing
>> calls were removed and cpuid_data is now initialized completely in one
>> call.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> Applied, thanks.
Ping. This bug fix for KVM is still missing in QEMU 1.7.
Regards,
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Gleb Natapov <gleb@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
kvm@vger.kernel.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH for 1.7] kvm: Fix uninitialized cpuid_data
Date: Wed, 20 Nov 2013 19:54:33 +0100 [thread overview]
Message-ID: <528D0569.3080308@weilnetz.de> (raw)
In-Reply-To: <20131107111516.GB7513@redhat.com>
Am 07.11.2013 12:15, schrieb Gleb Natapov:
> On Wed, Nov 06, 2013 at 10:35:27PM +0100, Stefan Weil wrote:
>> This error was reported by valgrind when running qemu-system-x86_64
>> with kvm:
>>
>> ==975== Conditional jump or move depends on uninitialised value(s)
>> ==975== at 0x521C38: cpuid_find_entry (kvm.c:176)
>> ==975== by 0x5235BA: kvm_arch_init_vcpu (kvm.c:686)
>> ==975== by 0x4D5175: kvm_init_vcpu (kvm-all.c:267)
>> ==975== by 0x45035B: qemu_kvm_cpu_thread_fn (cpus.c:858)
>> ==975== by 0xD361E0D: start_thread (pthread_create.c:311)
>> ==975== by 0xD65E9EC: clone (clone.S:113)
>> ==975== Uninitialised value was created by a stack allocation
>> ==975== at 0x5226E4: kvm_arch_init_vcpu (kvm.c:446)
>>
>> Instead of adding more memset calls for parts of cpuid_data, the existing
>> calls were removed and cpuid_data is now initialized completely in one
>> call.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> Applied, thanks.
Ping. This bug fix for KVM is still missing in QEMU 1.7.
Regards,
Stefan
next prev parent reply other threads:[~2013-11-20 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 21:35 [PATCH for 1.7] kvm: Fix uninitialized cpuid_data Stefan Weil
2013-11-06 21:35 ` [Qemu-devel] " Stefan Weil
2013-11-07 11:15 ` Gleb Natapov
2013-11-07 11:15 ` [Qemu-devel] " Gleb Natapov
2013-11-20 18:54 ` Stefan Weil [this message]
2013-11-20 18:54 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528D0569.3080308@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@amazon.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.