From: Andreas Platschek <andi.platschek@gmail.com>
To: wharms@bfs.de
Cc: gregkh@linuxfoundation.org, jslaby@suse.cz,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tty: replace mutex_lock() with tty_write_lock()
Date: Fri, 22 Nov 2013 08:22:19 +0000 [thread overview]
Message-ID: <528F143B.5020507@gmail.com> (raw)
In-Reply-To: <528F112B.4090404@bfs.de>
Hi,
On 11/22/2013 09:09 AM, walter harms wrote:
>
> Am 21.11.2013 20:12, schrieb Andreas Platschek:
>> Use tty_write_lock()/tty_write_unlock() consistently.
>>
>> This takes care of the following sparse warning:
>> drivers/tty/tty_io.c:1169:17: warning: context imbalance in 'tty_write_message' - unexpected unlock
>>
>> Signed-off-by: Andreas Platschek <andi.platschek@gmail.com>
>> ---
>> drivers/tty/tty_io.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
>> index 3a1a01a..13dca92 100644
>> --- a/drivers/tty/tty_io.c
>> +++ b/drivers/tty/tty_io.c
>> @@ -1165,7 +1165,7 @@ out:
>> void tty_write_message(struct tty_struct *tty, char *msg)
>> {
>> if (tty) {
>> - mutex_lock(&tty->atomic_write_lock);
>> + tty_write_lock(tty,0);
>> tty_lock(tty);
>> if (tty->ops->write && !test_bit(TTY_CLOSING, &tty->flags)) {
>> tty_unlock(tty);
> i am not an expert on this but you may need to replace that tty_unlock() with tty_write_unlock()
The tty_unlock() you see in the patch belongs to the tty_lock() right
after the tty_write_lock(), the tty_write_unlock() is already in place
without my patch.
tty_lock()/tty_unlock() and tty_write_lock()/tty_write_unlock() are
operating on different mutexes, both are needed here.
thx!
Andi
>
> re,
> wh
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Platschek <andi.platschek@gmail.com>
To: wharms@bfs.de
Cc: gregkh@linuxfoundation.org, jslaby@suse.cz,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tty: replace mutex_lock() with tty_write_lock()
Date: Fri, 22 Nov 2013 09:22:19 +0100 [thread overview]
Message-ID: <528F143B.5020507@gmail.com> (raw)
In-Reply-To: <528F112B.4090404@bfs.de>
Hi,
On 11/22/2013 09:09 AM, walter harms wrote:
>
> Am 21.11.2013 20:12, schrieb Andreas Platschek:
>> Use tty_write_lock()/tty_write_unlock() consistently.
>>
>> This takes care of the following sparse warning:
>> drivers/tty/tty_io.c:1169:17: warning: context imbalance in 'tty_write_message' - unexpected unlock
>>
>> Signed-off-by: Andreas Platschek <andi.platschek@gmail.com>
>> ---
>> drivers/tty/tty_io.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
>> index 3a1a01a..13dca92 100644
>> --- a/drivers/tty/tty_io.c
>> +++ b/drivers/tty/tty_io.c
>> @@ -1165,7 +1165,7 @@ out:
>> void tty_write_message(struct tty_struct *tty, char *msg)
>> {
>> if (tty) {
>> - mutex_lock(&tty->atomic_write_lock);
>> + tty_write_lock(tty,0);
>> tty_lock(tty);
>> if (tty->ops->write && !test_bit(TTY_CLOSING, &tty->flags)) {
>> tty_unlock(tty);
> i am not an expert on this but you may need to replace that tty_unlock() with tty_write_unlock()
The tty_unlock() you see in the patch belongs to the tty_lock() right
after the tty_write_lock(), the tty_write_unlock() is already in place
without my patch.
tty_lock()/tty_unlock() and tty_write_lock()/tty_write_unlock() are
operating on different mutexes, both are needed here.
thx!
Andi
>
> re,
> wh
next prev parent reply other threads:[~2013-11-22 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 19:12 [PATCH] tty: replace mutex_lock() with tty_write_lock() Andreas Platschek
2013-11-21 19:12 ` Andreas Platschek
2013-11-22 8:09 ` walter harms
2013-11-22 8:09 ` walter harms
2013-11-22 8:22 ` Andreas Platschek [this message]
2013-11-22 8:22 ` Andreas Platschek
2013-11-22 8:29 ` Dan Carpenter
2013-11-22 8:29 ` Dan Carpenter
2013-11-22 8:25 ` Dan Carpenter
2013-11-22 8:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528F143B.5020507@gmail.com \
--to=andi.platschek@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.