From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 0/2] Add support for the Allwinner A31 DMA Controller
Date: Wed, 21 May 2014 18:04:43 +0200 [thread overview]
Message-ID: <5291281.0OW8pVdbhQ@wuerfel> (raw)
In-Reply-To: <20140521155551.GV27329@lukather>
On Wednesday 21 May 2014 17:55:51 Maxime Ripard wrote:
> On Wed, May 21, 2014 at 05:23:41PM +0200, Arnd Bergmann wrote:
> > On Wednesday 21 May 2014 17:15:54 Maxime Ripard wrote:
> > > Changes from v7:
> > > - select DMA_OF, since we're only relying on DT
> > >
> >
> > I missed the discussion about this issue, but it seems wrong to me.
> > DMA_OF is currently enabled if we have both DMAENGINE and OF turned on.
> >
> > If OF is disabled but DMA_OF gets selected by DMA_SUN6I, what happens?
>
> Is that even possible with a multiplatform-based platform?
It's not possible for ARCH_SUNXI or any other that depends on
ARCH_MULTIPLATFORM. I just noticed that you have 'depends on ARCH_SUNXI',
so the 'select DMA_OF' statement is just redundant, not wrong.
However, if the driver was 'depends on ARCH_SUNXI || COMPILE_TEST' as many
others are nowadays, it would be a bug.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
andriy.shevchenko@intel.com, Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, zhuzhenhua@allwinnertech.com,
shuge@allwinnertech.com, linux-sunxi@googlegroups.com,
kevin.z.m.zh@gmail.com, sunny@allwinnertech.com,
dmaengine@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH v8 0/2] Add support for the Allwinner A31 DMA Controller
Date: Wed, 21 May 2014 18:04:43 +0200 [thread overview]
Message-ID: <5291281.0OW8pVdbhQ@wuerfel> (raw)
In-Reply-To: <20140521155551.GV27329@lukather>
On Wednesday 21 May 2014 17:55:51 Maxime Ripard wrote:
> On Wed, May 21, 2014 at 05:23:41PM +0200, Arnd Bergmann wrote:
> > On Wednesday 21 May 2014 17:15:54 Maxime Ripard wrote:
> > > Changes from v7:
> > > - select DMA_OF, since we're only relying on DT
> > >
> >
> > I missed the discussion about this issue, but it seems wrong to me.
> > DMA_OF is currently enabled if we have both DMAENGINE and OF turned on.
> >
> > If OF is disabled but DMA_OF gets selected by DMA_SUN6I, what happens?
>
> Is that even possible with a multiplatform-based platform?
It's not possible for ARCH_SUNXI or any other that depends on
ARCH_MULTIPLATFORM. I just noticed that you have 'depends on ARCH_SUNXI',
so the 'select DMA_OF' statement is just redundant, not wrong.
However, if the driver was 'depends on ARCH_SUNXI || COMPILE_TEST' as many
others are nowadays, it would be a bug.
Arnd
next prev parent reply other threads:[~2014-05-21 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 15:15 [PATCH v8 0/2] Add support for the Allwinner A31 DMA Controller Maxime Ripard
2014-05-21 15:15 ` Maxime Ripard
2014-05-21 15:15 ` [PATCH v8 1/2] Documentation: dt: Add Allwinner A31 DMA controller bindings Maxime Ripard
2014-05-21 15:15 ` Maxime Ripard
2014-05-21 15:15 ` [PATCH v8 2/2] dmaengine: sun6i: Add driver for the Allwinner A31 DMA controller Maxime Ripard
2014-05-21 15:15 ` Maxime Ripard
2014-05-21 15:23 ` [PATCH v8 0/2] Add support for the Allwinner A31 DMA Controller Arnd Bergmann
2014-05-21 15:23 ` Arnd Bergmann
2014-05-21 15:55 ` Maxime Ripard
2014-05-21 15:55 ` Maxime Ripard
2014-05-21 16:04 ` Arnd Bergmann [this message]
2014-05-21 16:04 ` Arnd Bergmann
2014-05-22 11:58 ` Maxime Ripard
2014-05-22 11:58 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5291281.0OW8pVdbhQ@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.