All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@euromail.se>
To: Michele Baldessari <michele@acksyn.org>
Cc: jwboyer@fedoraproject.org, Guenter Roeck <linux@roeck-us.net>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	bugzilla@colorremedies.com, Chris Murphy <chris@cmurf.com>
Subject: Re: [lm-sensors] small regression: hwmon: (applesmc) Check key count before proceeding - 5f451386430
Date: Sun, 24 Nov 2013 09:44:27 +0000	[thread overview]
Message-ID: <5291CA7B.3080904@euromail.se> (raw)
In-Reply-To: <20131124092359.4241e633@fante.int.rhx>

Hi Michele,

> The issue Chris has seen in Fedora on one MacBookPro4,1
> (https://bugzilla.redhat.com/show_bug.cgi?id\x1033414) is that this
> machine returns a huge number from read_register_count() so now we will
> try to allocate an insane amount of memory and we will barf:
> [    8.603053] applesmc: key count changed from 261 to 1392508929

I was under the impression that this machine was tested before, and that

commit 25f2bd7f5add608c1d1405938f39c96927b275ca
Author: Henrik Rydberg <rydberg@euromail.se>
Date:   Wed Oct 2 19:15:03 2013 +0200

    hwmon: (applesmc) Always read until end of data

resolved this problem? But if the kernel under test is 3.11.8, both patches are
already present... Chris, could you please sched some light on this before
moving on?

Thanks,
Henrik


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Henrik Rydberg <rydberg@euromail.se>
To: Michele Baldessari <michele@acksyn.org>
Cc: jwboyer@fedoraproject.org, Guenter Roeck <linux@roeck-us.net>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	bugzilla@colorremedies.com, Chris Murphy <chris@cmurf.com>
Subject: Re: small regression: hwmon: (applesmc) Check key count before proceeding - 5f4513864304672e6ea9eac60583eeac32e679f2
Date: Sun, 24 Nov 2013 10:44:27 +0100	[thread overview]
Message-ID: <5291CA7B.3080904@euromail.se> (raw)
In-Reply-To: <20131124092359.4241e633@fante.int.rhx>

Hi Michele,

> The issue Chris has seen in Fedora on one MacBookPro4,1
> (https://bugzilla.redhat.com/show_bug.cgi?id=1033414) is that this
> machine returns a huge number from read_register_count() so now we will
> try to allocate an insane amount of memory and we will barf:
> [    8.603053] applesmc: key count changed from 261 to 1392508929

I was under the impression that this machine was tested before, and that

commit 25f2bd7f5add608c1d1405938f39c96927b275ca
Author: Henrik Rydberg <rydberg@euromail.se>
Date:   Wed Oct 2 19:15:03 2013 +0200

    hwmon: (applesmc) Always read until end of data

resolved this problem? But if the kernel under test is 3.11.8, both patches are
already present... Chris, could you please sched some light on this before
moving on?

Thanks,
Henrik


  reply	other threads:[~2013-11-24  9:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-24  9:23 [lm-sensors] small regression: hwmon: (applesmc) Check key count before proceeding - 5f4513864304672 Michele Baldessari
2013-11-24  9:23 ` small regression: hwmon: (applesmc) Check key count before proceeding - 5f4513864304672e6ea9eac60583eeac32e679f2 Michele Baldessari
2013-11-24  9:44 ` Henrik Rydberg [this message]
2013-11-24  9:44   ` Henrik Rydberg
2013-11-24 16:22   ` [lm-sensors] small regression: hwmon: (applesmc) Check key count before proceeding - 5f451386430 Chris Murphy
2013-11-24 16:22     ` small regression: hwmon: (applesmc) Check key count before proceeding - 5f4513864304672e6ea9eac60583eeac32e679f2 Chris Murphy
2013-11-24 16:57     ` [lm-sensors] small regression: hwmon: (applesmc) Check key count before proceeding - 5f451386430 Henrik Rydberg
2013-11-24 16:57       ` small regression: hwmon: (applesmc) Check key count before proceeding - 5f4513864304672e6ea9eac60583eeac32e679f2 Henrik Rydberg
2013-11-24 17:02       ` [lm-sensors] small regression: hwmon: (applesmc) Check key count before proceeding - 5f451386430 Chris Murphy
2013-11-24 17:02         ` small regression: hwmon: (applesmc) Check key count before proceeding - 5f4513864304672e6ea9eac60583eeac32e679f2 Chris Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5291CA7B.3080904@euromail.se \
    --to=rydberg@euromail.se \
    --cc=bugzilla@colorremedies.com \
    --cc=chris@cmurf.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=michele@acksyn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.