From: "ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>, <wim@iguana.be>,
<nsekhar@ti.com>, <linux-watchdog@vger.kernel.org>,
<devicetree@vger.kernel.org>, <mark.rutland@arm.com>,
<pawel.moll@arm.com>, <swarren@wwwdotorg.org>,
<ijc+devicetree@hellion.org.uk>, <galak@kernel.crashing.org>,
<rob.herring@calxeda.com>, <linux-kernel@vger.kernel.org>,
<grant.likely@linaro.org>
Subject: Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property
Date: Mon, 25 Nov 2013 12:59:45 +0200 [thread overview]
Message-ID: <52932DA1.8040204@ti.com> (raw)
In-Reply-To: <201311231857.47104.arnd@arndb.de>
On 11/23/2013 07:57 PM, Arnd Bergmann wrote:
> On Wednesday 06 November 2013, ivan.khoronzhuk wrote:
>> @@ -7,6 +7,10 @@ Required properties:
>>
>> - reg : Should contain WDT registers location and length
>>
>> +- clocks: phandle reference to the controller clock.
>> + Required only for Keystone arch.
>> + See clock-bindings.txt
>> +
>> Optional properties:
>>
>> - timeout-sec: Contains the watchdog timeout in seconds
>
> I think it should really be listed under "Optional properties" and the
> reference to Keystone removed. Note how the binding would need
> to change otherwise if another platform started to use the clock, which
> is a little silly.
>
> Arnd
>
Ok, I'll move clocks property under "Optional properties" and describe it
as following:
Optional properties:
- timeout-sec : Contains the watchdog timeout in seconds
- clocks: phandle reference to the controller clock.
Needed if platform uses clocks.
See clock-bindings.txt
FYI:
The new patch series had been already presented, where the patches
"watchdog: davinci: add "clocks" property" and
"watchdog: davinci: reuse driver for keystone arch" were combined.
http://www.spinics.net/lists/devicetree/msg12542.html
--
Regards,
Ivan Khoronzhuk
WARNING: multiple messages have this Message-ID (diff)
From: ivan.khoronzhuk@ti.com (ivan.khoronzhuk)
To: linux-arm-kernel@lists.infradead.org
Subject: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property
Date: Mon, 25 Nov 2013 12:59:45 +0200 [thread overview]
Message-ID: <52932DA1.8040204@ti.com> (raw)
In-Reply-To: <201311231857.47104.arnd@arndb.de>
On 11/23/2013 07:57 PM, Arnd Bergmann wrote:
> On Wednesday 06 November 2013, ivan.khoronzhuk wrote:
>> @@ -7,6 +7,10 @@ Required properties:
>>
>> - reg : Should contain WDT registers location and length
>>
>> +- clocks: phandle reference to the controller clock.
>> + Required only for Keystone arch.
>> + See clock-bindings.txt
>> +
>> Optional properties:
>>
>> - timeout-sec: Contains the watchdog timeout in seconds
>
> I think it should really be listed under "Optional properties" and the
> reference to Keystone removed. Note how the binding would need
> to change otherwise if another platform started to use the clock, which
> is a little silly.
>
> Arnd
>
Ok, I'll move clocks property under "Optional properties" and describe it
as following:
Optional properties:
- timeout-sec : Contains the watchdog timeout in seconds
- clocks: phandle reference to the controller clock.
Needed if platform uses clocks.
See clock-bindings.txt
FYI:
The new patch series had been already presented, where the patches
"watchdog: davinci: add "clocks" property" and
"watchdog: davinci: reuse driver for keystone arch" were combined.
http://www.spinics.net/lists/devicetree/msg12542.html
--
Regards,
Ivan Khoronzhuk
WARNING: multiple messages have this Message-ID (diff)
From: "ivan.khoronzhuk" <ivan.khoronzhuk-l0cyMroinI0@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Santosh Shilimkar
<santosh.shilimkar-l0cyMroinI0@public.gmane.org>,
wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org,
nsekhar-l0cyMroinI0@public.gmane.org,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property
Date: Mon, 25 Nov 2013 12:59:45 +0200 [thread overview]
Message-ID: <52932DA1.8040204@ti.com> (raw)
In-Reply-To: <201311231857.47104.arnd-r2nGTMty4D4@public.gmane.org>
On 11/23/2013 07:57 PM, Arnd Bergmann wrote:
> On Wednesday 06 November 2013, ivan.khoronzhuk wrote:
>> @@ -7,6 +7,10 @@ Required properties:
>>
>> - reg : Should contain WDT registers location and length
>>
>> +- clocks: phandle reference to the controller clock.
>> + Required only for Keystone arch.
>> + See clock-bindings.txt
>> +
>> Optional properties:
>>
>> - timeout-sec: Contains the watchdog timeout in seconds
>
> I think it should really be listed under "Optional properties" and the
> reference to Keystone removed. Note how the binding would need
> to change otherwise if another platform started to use the clock, which
> is a little silly.
>
> Arnd
>
Ok, I'll move clocks property under "Optional properties" and describe it
as following:
Optional properties:
- timeout-sec : Contains the watchdog timeout in seconds
- clocks: phandle reference to the controller clock.
Needed if platform uses clocks.
See clock-bindings.txt
FYI:
The new patch series had been already presented, where the patches
"watchdog: davinci: add "clocks" property" and
"watchdog: davinci: reuse driver for keystone arch" were combined.
http://www.spinics.net/lists/devicetree/msg12542.html
--
Regards,
Ivan Khoronzhuk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-25 11:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1383680783-12114-8-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-06 11:32 ` Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property ivan.khoronzhuk
2013-11-06 11:32 ` ivan.khoronzhuk
2013-11-06 11:32 ` ivan.khoronzhuk
2013-11-12 15:40 ` Santosh Shilimkar
2013-11-12 15:40 ` Santosh Shilimkar
2013-11-12 15:40 ` Santosh Shilimkar
2013-11-17 2:28 ` Guenter Roeck
2013-11-17 2:28 ` Guenter Roeck
2013-11-17 2:28 ` Guenter Roeck
2013-11-18 15:26 ` ivan.khoronzhuk
2013-11-18 15:26 ` ivan.khoronzhuk
2013-11-18 15:26 ` ivan.khoronzhuk
2013-11-23 17:57 ` Arnd Bergmann
2013-11-23 17:57 ` Arnd Bergmann
2013-11-23 17:57 ` Arnd Bergmann
2013-11-25 10:59 ` ivan.khoronzhuk [this message]
2013-11-25 10:59 ` ivan.khoronzhuk
2013-11-25 10:59 ` ivan.khoronzhuk
2013-11-25 12:15 ` Mark Rutland
2013-11-25 12:15 ` Mark Rutland
2013-11-25 12:15 ` Mark Rutland
2013-11-25 12:41 ` ivan.khoronzhuk
2013-11-25 12:41 ` ivan.khoronzhuk
2013-11-25 12:41 ` ivan.khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52932DA1.8040204@ti.com \
--to=ivan.khoronzhuk@ti.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@kernel.crashing.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.