Re: [PATCH 1/6] watchdog: davinci: change driver to use WDT core

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>
To: Sekhar Nori <nsekhar@ti.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Wim Van Sebroeck <wim@iguana.be>,
	<linux-watchdog@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: Grant Likely <grant.likely@linaro.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Kumar Gala <galak@kernel.crashing.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Strashko Grygorii <grygorii.strashko@ti.com>
Subject: Re: [PATCH 1/6] watchdog: davinci: change driver to use WDT core
Date: Mon, 25 Nov 2013 14:06:30 +0200	[thread overview]
Message-ID: <52933D46.6090901@ti.com> (raw)
In-Reply-To: <52933AE4.3070608@ti.com>

On 11/25/2013 01:56 PM, Sekhar Nori wrote:
> On Monday 18 November 2013 10:48 PM, Ivan Khoronzhuk wrote:
>> @@ -211,29 +129,34 @@ static int davinci_wdt_probe(struct platform_device *pdev)
>>
>>   	clk_prepare_enable(wdt_clk);
>>
>> -	if (heartbeat < 1 || heartbeat > MAX_HEARTBEAT)
>> -		heartbeat = DEFAULT_HEARTBEAT;
>> +	wdd			= &wdt_wdd;
>> +	wdd->info		= &davinci_wdt_info;
>> +	wdd->ops		= &davinci_wdt_ops;
>> +	wdd->min_timeout 	= 1;
>> +	wdd->max_timeout 	= MAX_HEARTBEAT;
>
> Some checkpatch warnings. Please fix.
>
> WARNING: please, no space before tabs
> #273: FILE: drivers/watchdog/davinci_wdt.c:135:
> +^Iwdd->min_timeout ^I= 1;$
>
> WARNING: please, no space before tabs
> #274: FILE: drivers/watchdog/davinci_wdt.c:136:
> +^Iwdd->max_timeout ^I= MAX_HEARTBEAT;$
>
> total: 0 errors, 2 warnings, 0 checks, 249 lines checked
>
> Thanks,
> sekhar
>

Thanks, I will

-- 
Regards,
Ivan Khoronzhuk

WARNING: multiple messages have this Message-ID (diff)

From: ivan.khoronzhuk@ti.com (ivan.khoronzhuk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] watchdog: davinci: change driver to use WDT core
Date: Mon, 25 Nov 2013 14:06:30 +0200	[thread overview]
Message-ID: <52933D46.6090901@ti.com> (raw)
In-Reply-To: <52933AE4.3070608@ti.com>

On 11/25/2013 01:56 PM, Sekhar Nori wrote:
> On Monday 18 November 2013 10:48 PM, Ivan Khoronzhuk wrote:
>> @@ -211,29 +129,34 @@ static int davinci_wdt_probe(struct platform_device *pdev)
>>
>>   	clk_prepare_enable(wdt_clk);
>>
>> -	if (heartbeat < 1 || heartbeat > MAX_HEARTBEAT)
>> -		heartbeat = DEFAULT_HEARTBEAT;
>> +	wdd			= &wdt_wdd;
>> +	wdd->info		= &davinci_wdt_info;
>> +	wdd->ops		= &davinci_wdt_ops;
>> +	wdd->min_timeout 	= 1;
>> +	wdd->max_timeout 	= MAX_HEARTBEAT;
>
> Some checkpatch warnings. Please fix.
>
> WARNING: please, no space before tabs
> #273: FILE: drivers/watchdog/davinci_wdt.c:135:
> +^Iwdd->min_timeout ^I= 1;$
>
> WARNING: please, no space before tabs
> #274: FILE: drivers/watchdog/davinci_wdt.c:136:
> +^Iwdd->max_timeout ^I= MAX_HEARTBEAT;$
>
> total: 0 errors, 2 warnings, 0 checks, 249 lines checked
>
> Thanks,
> sekhar
>

Thanks, I will

-- 
Regards,
Ivan Khoronzhuk

WARNING: multiple messages have this Message-ID (diff)

From: "ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>
To: Sekhar Nori <nsekhar@ti.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Wim Van Sebroeck <wim@iguana.be>,
	linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Strashko Grygorii <grygorii.strashko@ti.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@kernel.crashing.org>,
	Rob Herring <rob.herring@calxeda.com>,
	linux-kernel@vger.kernel.org,
	Grant Likely <grant.likely@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] watchdog: davinci: change driver to use WDT core
Date: Mon, 25 Nov 2013 14:06:30 +0200	[thread overview]
Message-ID: <52933D46.6090901@ti.com> (raw)
In-Reply-To: <52933AE4.3070608@ti.com>

On 11/25/2013 01:56 PM, Sekhar Nori wrote:
> On Monday 18 November 2013 10:48 PM, Ivan Khoronzhuk wrote:
>> @@ -211,29 +129,34 @@ static int davinci_wdt_probe(struct platform_device *pdev)
>>
>>   	clk_prepare_enable(wdt_clk);
>>
>> -	if (heartbeat < 1 || heartbeat > MAX_HEARTBEAT)
>> -		heartbeat = DEFAULT_HEARTBEAT;
>> +	wdd			= &wdt_wdd;
>> +	wdd->info		= &davinci_wdt_info;
>> +	wdd->ops		= &davinci_wdt_ops;
>> +	wdd->min_timeout 	= 1;
>> +	wdd->max_timeout 	= MAX_HEARTBEAT;
>
> Some checkpatch warnings. Please fix.
>
> WARNING: please, no space before tabs
> #273: FILE: drivers/watchdog/davinci_wdt.c:135:
> +^Iwdd->min_timeout ^I= 1;$
>
> WARNING: please, no space before tabs
> #274: FILE: drivers/watchdog/davinci_wdt.c:136:
> +^Iwdd->max_timeout ^I= MAX_HEARTBEAT;$
>
> total: 0 errors, 2 warnings, 0 checks, 249 lines checked
>
> Thanks,
> sekhar
>

Thanks, I will

-- 
Regards,
Ivan Khoronzhuk

next prev parent reply	other threads:[~2013-11-25 12:07 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 17:18 [PATCH v2 0/6] Update Davinci watchdog driver Ivan Khoronzhuk
2013-11-18 17:18 ` Ivan Khoronzhuk
2013-11-18 17:18 ` Ivan Khoronzhuk
2013-11-18 17:18 ` [PATCH 1/6] watchdog: davinci: change driver to use WDT core Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-19  5:12   ` Guenter Roeck
2013-11-19  5:12     ` Guenter Roeck
2013-11-19  5:12     ` Guenter Roeck
2013-11-19 16:17     ` Grygorii Strashko
2013-11-19 16:17       ` Grygorii Strashko
2013-11-19 16:17       ` Grygorii Strashko
2013-11-25 11:56   ` Sekhar Nori
2013-11-25 11:56     ` Sekhar Nori
2013-11-25 11:56     ` Sekhar Nori
2013-11-25 12:06     ` ivan.khoronzhuk [this message]
2013-11-25 12:06       ` ivan.khoronzhuk
2013-11-25 12:06       ` ivan.khoronzhuk
2013-11-18 17:18 ` [PATCH 2/6] watchdog: davinci: use davinci_wdt_device structure to hold device data Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-18 17:18 ` [PATCH 3/6] watchdog: davinci: add GET_TIMELEFT option support Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-19  5:14   ` Guenter Roeck
2013-11-19  5:14     ` Guenter Roeck
2013-11-19  5:14     ` Guenter Roeck
2013-11-18 17:18 ` [PATCH 4/6] watchdog: davinci: add "timeout-sec" property Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-19  5:15   ` Guenter Roeck
2013-11-19  5:15     ` Guenter Roeck
2013-11-18 17:18 ` [PATCH 5/6] watchdog: davinci: reuse driver for keystone arch Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-19  5:16   ` Guenter Roeck
2013-11-19  5:16     ` Guenter Roeck
2013-11-18 17:18 ` [PATCH 6/6] arm: dts: keystone: add watchdog entry Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-18 17:18   ` Ivan Khoronzhuk
2013-11-25 13:06 ` [PATCH v2 0/6] Update Davinci watchdog driver Sekhar Nori
2013-11-25 13:06   ` Sekhar Nori
2013-11-25 13:06   ` Sekhar Nori
2013-11-25 13:19   ` ivan.khoronzhuk
2013-11-25 13:19     ` ivan.khoronzhuk
2013-11-25 13:19     ` ivan.khoronzhuk
2013-11-25 16:44     ` ivan.khoronzhuk
2013-11-25 16:44       ` ivan.khoronzhuk
2013-11-25 16:44       ` ivan.khoronzhuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52933D46.6090901@ti.com \
    --to=ivan.khoronzhuk@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@kernel.crashing.org \
    --cc=grant.likely@linaro.org \
    --cc=grygorii.strashko@ti.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nsekhar@ti.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=swarren@wwwdotorg.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.