From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>,
tiwai@suse.de, perex@perex.cz
Cc: alsa-devel@alsa-project.org,
linux1394-devel@lists.sourceforge.net,
ffado-devel@lists.sourceforge.net
Subject: Re: [PATCH 02/17] firewire-lib: Add macros instead of fixed value for AMDTP
Date: Mon, 25 Nov 2013 16:27:00 +0100 [thread overview]
Message-ID: <52936C44.7070606@ladisch.de> (raw)
In-Reply-To: <1385186884-8259-3-git-send-email-o-takashi@sakamocchi.jp>
Takashi Sakamoto wrote:
> This patch adds some macros instead of fixed value for AMDTP in IEC 61883-6.
> These macros will also be used by followed patches.
> +++ b/sound/firewire/amdtp.c
> +/*
> + * Audio and Music transfer protocol specific parameters
> + * only "Clock-based rate controll mode" is supported
^^^^^^^^
control
> - return 0xffff; /* no info */
> + return CIP_SYT_NO_INFO; /* no info */
The comment is now superfluous.
Regards,
Clemens
next prev parent reply other threads:[~2013-11-25 15:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 6:07 [RFC][PATCH 00/17] Enhancement for firewire-lib Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 01/17] firewire-lib: Rename functions, structure, member for both direction Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 02/17] firewire-lib: Add macros instead of fixed value for AMDTP Takashi Sakamoto
2013-11-25 15:27 ` Clemens Ladisch [this message]
2013-11-26 9:50 ` Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 03/17] firewire-lib: Add 'direction' member to 'amdtp_stream' structure Takashi Sakamoto
2013-11-25 15:27 ` [alsa-devel] " Clemens Ladisch
2013-11-26 10:01 ` Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 04/17] firewire-lib: Split some codes into functions to reuse in future Takashi Sakamoto
2013-11-25 15:27 ` [alsa-devel] " Clemens Ladisch
2013-11-26 10:52 ` Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 05/17] firewire-lib: Add support for AMDTP transmit stream and PCM capture Takashi Sakamoto
2013-11-25 15:27 ` [alsa-devel] " Clemens Ladisch
2013-11-26 10:50 ` Takashi Sakamoto
2013-11-26 11:17 ` Takashi Sakamoto
2013-12-18 11:57 ` Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 06/17] firewire-lib: Add support for MIDI capture/playback Takashi Sakamoto
2013-11-25 15:27 ` [alsa-devel] " Clemens Ladisch
2013-11-26 12:04 ` Takashi Sakamoto
2013-11-26 13:02 ` Clemens Ladisch
2013-11-26 17:10 ` Takashi Sakamoto
2013-11-26 17:50 ` Clemens Ladisch
2013-11-27 8:33 ` Alan Horstmann
2013-11-27 16:12 ` Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 07/17] firewire-lib: give syt value to handle_out_packet() Takashi Sakamoto
2013-11-25 15:27 ` [alsa-devel] " Clemens Ladisch
2013-11-26 10:59 ` Takashi Sakamoto
2013-12-18 12:29 ` Takashi Sakamoto
2013-12-18 17:26 ` Clemens Ladisch
2013-11-23 6:07 ` [PATCH 08/17] firewire-lib: Add support for duplex streams with synchronization Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 09/17] firewire-lib: Add sort function for transmitted packet Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 10/17] firewire-lib: Add transfer delay to synchronized duplex streams Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 11/17] firewire-lib: Add support for channel mapping Takashi Sakamoto
2013-11-23 6:07 ` [PATCH 12/17] firewire-lib: Rename macros, variables and functions for CMP Takashi Sakamoto
2013-11-23 6:08 ` [PATCH 13/17] firewire-lib: Add 'direction' member to 'cmp_connection' structure Takashi Sakamoto
2013-11-23 6:08 ` [PATCH 14/17] firewire-lib: Add handling output connection by CMP Takashi Sakamoto
2013-11-23 6:08 ` [PATCH 15/17] firewire-lib: Add a new function to check others' connection Takashi Sakamoto
2013-11-23 6:08 ` [PATCH 16/17] firewire-lib: Add some AV/C general commands Takashi Sakamoto
2013-11-23 6:08 ` [PATCH 17/17] firewire-lib: Add quirks for Fireworks chipset Takashi Sakamoto
2013-11-25 3:13 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52936C44.7070606@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=ffado-devel@lists.sourceforge.net \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.