Re: [PATCH 05/17] firewire-lib: Add support for AMDTP transmit stream and PCM capture

[Takashi Sakamoto <o-takashi@sakamocchi.jp>]

(Nov 26 2013 19:50), Takashi Sakamoto wrote:
>>> +    s->data_block_counter = (s->data_block_counter + data_blocks) &
>>> 0xff;
>>> +    if (s->data_block_counter != data_block_counter) {
>>> +        dev_err(&s->unit->device,
>>> +            "Detect uncontinuity of CIP packets\n");
>>> +        s->data_block_counter = data_block_counter;
>>> +        return;
>>> +    }
>>
>> The correct thing to do would be to insert the missing samples, or to
>> stop the stream.
>
> OK. But I remember there are some devices which transmits packets with
> 0x0000 in its SYT field (Digidesign 003 Rack, I don't touch its
> development.). So I want to remove these codes if possible.

Oops! I was confused between DBC and SYT. Digidesign 003 Rack transmits 
DBC correctly. Please forget my reply about this...

Here I think it better to insert the missing samples. Then just output 
information and continue to handle samples.


Thank you

Takashi Sakamoto


------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk