Re: [PATCH 1/3] mtd: nand: davinci: reuse driver for Keystone arch

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, grygorii.strashko@ti.com,
	Russell King <linux@arm.linux.org.uk>,
	Pawel Moll <pawel.moll@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@kernel.crashing.org>,
	Rob Herring <rob.herring@calxeda.com>,
	linux-kernel@vger.kernel.org,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Rob Landley <rob@landley.net>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] mtd: nand: davinci: reuse driver for Keystone arch
Date: Mon, 25 Nov 2013 17:57:30 +0200	[thread overview]
Message-ID: <5293736A.2060108@ti.com> (raw)
In-Reply-To: <201311231915.29643.arnd@arndb.de>

On 11/23/2013 08:15 PM, Arnd Bergmann wrote:
> On Wednesday 20 November 2013, Ivan Khoronzhuk wrote:
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 __initconst = {
>>   #if defined(CONFIG_OF)
>>   static const struct of_device_id davinci_nand_of_match[] = {
>>          {.compatible = "ti,davinci-nand", },
>> +       {.compatible = "ti,keystone-nand", },
>>          {},
>>   };
>>   MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>
> Same comment as for the watchdog driver: when the devices are actually compatible,
> the driver does not need to know the new string, the preferred method is to
> set both strings from the .dts file.
>
> 	Arnd
>

Thanks. I'll correct it.

-- 
Regards,
Ivan Khoronzhuk

WARNING: multiple messages have this Message-ID (diff)

From: ivan.khoronzhuk@ti.com (ivan.khoronzhuk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mtd: nand: davinci: reuse driver for Keystone arch
Date: Mon, 25 Nov 2013 17:57:30 +0200	[thread overview]
Message-ID: <5293736A.2060108@ti.com> (raw)
In-Reply-To: <201311231915.29643.arnd@arndb.de>

On 11/23/2013 08:15 PM, Arnd Bergmann wrote:
> On Wednesday 20 November 2013, Ivan Khoronzhuk wrote:
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 __initconst = {
>>   #if defined(CONFIG_OF)
>>   static const struct of_device_id davinci_nand_of_match[] = {
>>          {.compatible = "ti,davinci-nand", },
>> +       {.compatible = "ti,keystone-nand", },
>>          {},
>>   };
>>   MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>
> Same comment as for the watchdog driver: when the devices are actually compatible,
> the driver does not need to know the new string, the preferred method is to
> set both strings from the .dts file.
>
> 	Arnd
>

Thanks. I'll correct it.

-- 
Regards,
Ivan Khoronzhuk

WARNING: multiple messages have this Message-ID (diff)

From: "ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Rob Landley <rob@landley.net>,
	Russell King <linux@arm.linux.org.uk>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, grygorii.strashko@ti.com,
	Pawel Moll <pawel.moll@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@kernel.crashing.org>,
	Rob Herring <rob.herring@calxeda.com>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] mtd: nand: davinci: reuse driver for Keystone arch
Date: Mon, 25 Nov 2013 17:57:30 +0200	[thread overview]
Message-ID: <5293736A.2060108@ti.com> (raw)
In-Reply-To: <201311231915.29643.arnd@arndb.de>

On 11/23/2013 08:15 PM, Arnd Bergmann wrote:
> On Wednesday 20 November 2013, Ivan Khoronzhuk wrote:
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 __initconst = {
>>   #if defined(CONFIG_OF)
>>   static const struct of_device_id davinci_nand_of_match[] = {
>>          {.compatible = "ti,davinci-nand", },
>> +       {.compatible = "ti,keystone-nand", },
>>          {},
>>   };
>>   MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>
> Same comment as for the watchdog driver: when the devices are actually compatible,
> the driver does not need to know the new string, the preferred method is to
> set both strings from the .dts file.
>
> 	Arnd
>

Thanks. I'll correct it.

-- 
Regards,
Ivan Khoronzhuk

WARNING: multiple messages have this Message-ID (diff)

From: "ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Rob Landley <rob@landley.net>,
	Russell King <linux@arm.linux.org.uk>,
	Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
	<grygorii.strashko@ti.com>, Pawel Moll <pawel.moll@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@kernel.crashing.org>,
	Rob Herring <rob.herring@calxeda.com>,
	<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 1/3] mtd: nand: davinci: reuse driver for Keystone arch
Date: Mon, 25 Nov 2013 17:57:30 +0200	[thread overview]
Message-ID: <5293736A.2060108@ti.com> (raw)
In-Reply-To: <201311231915.29643.arnd@arndb.de>

On 11/23/2013 08:15 PM, Arnd Bergmann wrote:
> On Wednesday 20 November 2013, Ivan Khoronzhuk wrote:
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 __initconst = {
>>   #if defined(CONFIG_OF)
>>   static const struct of_device_id davinci_nand_of_match[] = {
>>          {.compatible = "ti,davinci-nand", },
>> +       {.compatible = "ti,keystone-nand", },
>>          {},
>>   };
>>   MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>
> Same comment as for the watchdog driver: when the devices are actually compatible,
> the driver does not need to know the new string, the preferred method is to
> set both strings from the .dts file.
>
> 	Arnd
>

Thanks. I'll correct it.

-- 
Regards,
Ivan Khoronzhuk

next prev parent reply	other threads:[~2013-11-25 15:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 16:24 [PATCH 0/3] Reuse davinci-nand driver for Keystone arch Ivan Khoronzhuk
2013-11-20 16:24 ` Ivan Khoronzhuk
2013-11-20 16:24 ` Ivan Khoronzhuk
2013-11-20 16:24 ` Ivan Khoronzhuk
2013-11-20 16:24 ` [PATCH 1/3] mtd: nand: davinci: reuse " Ivan Khoronzhuk
2013-11-20 16:24   ` Ivan Khoronzhuk
2013-11-20 16:24   ` Ivan Khoronzhuk
2013-11-20 16:24   ` Ivan Khoronzhuk
2013-11-23 18:15   ` Arnd Bergmann
2013-11-23 18:15     ` Arnd Bergmann
2013-11-23 18:15     ` Arnd Bergmann
2013-11-25 15:57     ` ivan.khoronzhuk [this message]
2013-11-25 15:57       ` ivan.khoronzhuk
2013-11-25 15:57       ` ivan.khoronzhuk
2013-11-25 15:57       ` ivan.khoronzhuk
2013-11-20 16:24 ` [PATCH 2/3] mtd: nand: davinci: don't set timings if AEMIF is used Ivan Khoronzhuk
2013-11-20 16:24   ` Ivan Khoronzhuk
2013-11-20 16:24   ` Ivan Khoronzhuk
2013-11-20 16:24   ` Ivan Khoronzhuk
2013-11-20 16:24 ` [PATCH 3/3] mtd: nand: davinci: don't request AEMIF address range Ivan Khoronzhuk
2013-11-20 16:24   ` Ivan Khoronzhuk
2013-11-20 16:24   ` Ivan Khoronzhuk
2013-11-20 16:24   ` Ivan Khoronzhuk
2013-11-20 20:17 ` [PATCH 0/3] Reuse davinci-nand driver for Keystone arch Grygorii Strashko
2013-11-20 20:17   ` Grygorii Strashko
2013-11-20 20:17   ` Grygorii Strashko
2013-11-20 20:17   ` Grygorii Strashko
2013-11-20 20:33   ` Santosh Shilimkar
2013-11-20 20:33     ` Santosh Shilimkar
2013-11-20 20:33     ` Santosh Shilimkar
2013-11-20 20:33     ` Santosh Shilimkar
2013-11-20 20:38     ` ivan.khoronzhuk
2013-11-20 20:38       ` ivan.khoronzhuk
2013-11-20 20:38       ` ivan.khoronzhuk
2013-11-20 20:38       ` ivan.khoronzhuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5293736A.2060108@ti.com \
    --to=ivan.khoronzhuk@ti.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@kernel.crashing.org \
    --cc=grygorii.strashko@ti.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=santosh.shilimkar@ti.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.