Re: [PATCH v6] can: sja1000: fix {pre,post}_irq() handling and IRQ handler return value

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 25.11.2013 09:54, Marc Kleine-Budde wrote:
> On 11/25/2013 12:03 AM, Marc Kleine-Budde wrote:
>> From: Oliver Hartkopp <socketcan@hartkopp.net>
>>
>> It has been reported that on PREEMPT_RT enabled system the peak SJA1000
>> hardware can trigger "irq X: nobody cared" errors.

This sentence of the description is not really related to the patch.

We all looked into the sja1000 driver due to the issue Austin reported and
detected the general problem in error handling then.

With PREEMPT_RT there are irq threads which might lead to Austins specific
problem ...

>>
>> This patch fixes the issue that the sja1000_interrupt() function may have
>> returned IRQ_NONE without processing the optional pre_irq() and post_irq()
>> function before. Further the irq processing counter 'n' is moved to the end of
>> the while statement to return correct IRQ_[NONE|HANDLED] values at error
>> conditions.
> 
> Austin, can you test if this patch solves your problem.

Austin should test it, right.

But that should not delay sending this patch to net/stable tree.

Sorry for the confusion. Following the mails must have been hard ;-)

Best regards,
Oliver