From: Richard Henderson <rth@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PULL for-1.7 v2 3/6] acpi-build: fix build on glib < 2.22
Date: Tue, 26 Nov 2013 06:24:53 +1000 [thread overview]
Message-ID: <5293B215.4030108@redhat.com> (raw)
In-Reply-To: <1385379990-32093-4-git-send-email-mst@redhat.com>
On 11/25/2013 09:48 PM, Michael S. Tsirkin wrote:
> g_string_vprintf was only introduced in 2.24 so switch to vsnprintf
> instead. A bit uglier but name size is fixed at 4 bytes here so it's
> easy.
You list 2.24 here,
> - GString *s = g_string_new("");
> + /* It would be nicer to use g_string_vprintf but it's only there in 2.22 */
... 2.22 here.
But https://developer.gnome.org/glib/2.28/glib-Strings.html#g-string-vprintf
says "since 2.14".
> + char s[] = "XXXX";
char s[5];
Initializing it is a waste of time.
r~
next prev parent reply other threads:[~2013-11-25 20:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 11:48 [Qemu-devel] [PULL for-1.7 v2 0/5] pc very last minute fixes for 1.7 Michael S. Tsirkin
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 1/6] s390x: fix flat file load on 32 bit systems Michael S. Tsirkin
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 2/6] pci: unregister vmstate_pcibus on unplug Michael S. Tsirkin
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 3/6] acpi-build: fix build on glib < 2.22 Michael S. Tsirkin
2013-11-25 20:24 ` Richard Henderson [this message]
2013-11-25 20:31 ` Michael S. Tsirkin
2013-11-25 20:37 ` Richard Henderson
2013-11-25 20:54 ` Michael S. Tsirkin
2013-11-25 21:15 ` Laszlo Ersek
2013-11-25 21:22 ` Eric Blake
2013-11-25 21:18 ` Richard Henderson
2013-11-25 21:26 ` Michael S. Tsirkin
2013-11-25 21:02 ` Michael S. Tsirkin
2013-11-25 21:21 ` Richard Henderson
2013-11-25 21:33 ` Michael S. Tsirkin
2013-11-25 21:57 ` Laszlo Ersek
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 4/6] acpi-build: fix build on glib < 2.14 Michael S. Tsirkin
2013-11-25 20:14 ` Erik Rull
2013-11-25 20:59 ` Michael S. Tsirkin
2013-11-25 21:01 ` Michael S. Tsirkin
2013-11-25 21:47 ` Richard Henderson
2013-11-25 22:41 ` Erik Rull
2013-11-25 20:26 ` Richard Henderson
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 5/6] Revert "e1000/rtl8139: update HMP NIC when every bit is written" Michael S. Tsirkin
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 6/6] configure: make --iasl option actually work Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293B215.4030108@redhat.com \
--to=rth@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.