From: pwalmsley@nvidia.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: clk: clk_round_rate() should return 0, not negative numbers, upon error
Date: Mon, 25 Nov 2013 16:03:06 -0800 [thread overview]
Message-ID: <5293E53A.5050103@nvidia.com> (raw)
In-Reply-To: <20131126000153.GY16735@n2100.arm.linux.org.uk>
On 11/25/2013 04:01 PM, Russell King - ARM Linux wrote:
> On Mon, Nov 25, 2013 at 03:55:33PM -0800, Paul Walmsley wrote:
>> Update the documentation for clk_round_rate() to state that it should
>> return 0 rather than a negative error code when it encounters an
>> error. This describes how the common clock framework currently works;
>> howeever, some clock code does not yet align to this.
>>
>> This change is to prepare for returning unsigned values from
>> clk_round_rate().
> You really ought to document why this is being changed here, to help
> sell the change to parties who are not aware of the background.
> Otherwise, it just looks like a gratuitous API change.
Will do and resend.
- Paul
WARNING: multiple messages have this Message-ID (diff)
From: Paul Walmsley <pwalmsley@nvidia.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Mike Turquette <mturquette@linaro.org>
Subject: Re: clk: clk_round_rate() should return 0, not negative numbers, upon error
Date: Mon, 25 Nov 2013 16:03:06 -0800 [thread overview]
Message-ID: <5293E53A.5050103@nvidia.com> (raw)
In-Reply-To: <20131126000153.GY16735@n2100.arm.linux.org.uk>
On 11/25/2013 04:01 PM, Russell King - ARM Linux wrote:
> On Mon, Nov 25, 2013 at 03:55:33PM -0800, Paul Walmsley wrote:
>> Update the documentation for clk_round_rate() to state that it should
>> return 0 rather than a negative error code when it encounters an
>> error. This describes how the common clock framework currently works;
>> howeever, some clock code does not yet align to this.
>>
>> This change is to prepare for returning unsigned values from
>> clk_round_rate().
> You really ought to document why this is being changed here, to help
> sell the change to parties who are not aware of the background.
> Otherwise, it just looks like a gratuitous API change.
Will do and resend.
- Paul
next prev parent reply other threads:[~2013-11-26 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 23:55 clk: clk_round_rate() should return 0, not negative numbers, upon error Paul Walmsley
2013-11-25 23:55 ` Paul Walmsley
2013-11-26 0:01 ` Russell King - ARM Linux
2013-11-26 0:01 ` Russell King - ARM Linux
2013-11-26 0:03 ` Paul Walmsley [this message]
2013-11-26 0:03 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293E53A.5050103@nvidia.com \
--to=pwalmsley@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.