From: Michal Simek <monstr@monstr.eu>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver
Date: Tue, 26 Nov 2013 08:22:05 +0000 [thread overview]
Message-ID: <52945A2D.3060609@monstr.eu> (raw)
In-Reply-To: <CAMuHMdVx_jkUMB=gS0CtguBPB4f3fNRx0z4hB4zRz9OC09SvsQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On 11/26/2013 09:19 AM, Geert Uytterhoeven wrote:
> On Tue, Nov 26, 2013 at 8:10 AM, Michal Simek <monstr@monstr.eu> wrote:
>> On 11/22/2013 05:34 AM, Stefan Kristiansson wrote:
>> This construction seems to me too complicated and can be simpler.
>>
>> What about this?
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
> Don't forget to check for res being non-NULL here.
yes. you are right - you have to do it.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <monstr@monstr.eu>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver
Date: Tue, 26 Nov 2013 09:22:05 +0100 [thread overview]
Message-ID: <52945A2D.3060609@monstr.eu> (raw)
In-Reply-To: <CAMuHMdVx_jkUMB=gS0CtguBPB4f3fNRx0z4hB4zRz9OC09SvsQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On 11/26/2013 09:19 AM, Geert Uytterhoeven wrote:
> On Tue, Nov 26, 2013 at 8:10 AM, Michal Simek <monstr@monstr.eu> wrote:
>> On 11/22/2013 05:34 AM, Stefan Kristiansson wrote:
>> This construction seems to me too complicated and can be simpler.
>>
>> What about this?
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
> Don't forget to check for res being non-NULL here.
yes. you are right - you have to do it.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2013-11-26 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 4:34 [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver Stefan Kristiansson
2013-11-22 4:34 ` Stefan Kristiansson
2013-11-24 14:12 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-24 14:12 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-26 6:55 ` Stefan Kristiansson
2013-11-26 6:55 ` Stefan Kristiansson
2013-11-26 7:10 ` Michal Simek
2013-11-26 7:10 ` Michal Simek
2013-11-26 8:13 ` Stefan Kristiansson
2013-11-26 8:13 ` Stefan Kristiansson
2013-11-26 8:19 ` Geert Uytterhoeven
2013-11-26 8:19 ` Geert Uytterhoeven
2013-11-26 8:22 ` Michal Simek [this message]
2013-11-26 8:22 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52945A2D.3060609@monstr.eu \
--to=monstr@monstr.eu \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.