From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Joe Perches <joe@perches.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] framebuffer: Fix int cast to pointer warnings
Date: Tue, 26 Nov 2013 14:51:04 +0000 [thread overview]
Message-ID: <5294B558.6030106@ti.com> (raw)
In-Reply-To: <1379646611.2021.7.camel@joe-AO722>
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
On 2013-09-20 06:10, Joe Perches wrote:
> Casts of int to pointer need additional casts to (unsigned long)
> when compiled for x86-64 to silence the compiler.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/video/arkfb.c | 2 +-
> drivers/video/vt8623fb.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/arkfb.c b/drivers/video/arkfb.c
> index b13f3f2..26fd4e4 100644
> --- a/drivers/video/arkfb.c
> +++ b/drivers/video/arkfb.c
> @@ -1016,7 +1016,7 @@ static int ark_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>
> pcibios_bus_to_resource(dev, &vga_res, &bus_reg);
>
> - par->state.vgabase = (void __iomem *) vga_res.start;
> + par->state.vgabase = (void __iomem *)(unsigned long)vga_res.start;
>
> /* FIXME get memsize */
> regval = vga_rseq(par->state.vgabase, 0x10);
> diff --git a/drivers/video/vt8623fb.c b/drivers/video/vt8623fb.c
> index 7e97c53..281d41b 100644
> --- a/drivers/video/vt8623fb.c
> +++ b/drivers/video/vt8623fb.c
> @@ -731,7 +731,7 @@ static int vt8623_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>
> pcibios_bus_to_resource(dev, &vga_res, &bus_reg);
>
> - par->state.vgabase = (void __iomem *) vga_res.start;
> + par->state.vgabase = (void __iomem *)(unsigned long)vga_res.start;
>
> /* Find how many physical memory there is on card */
> memsize1 = (vga_rseq(par->state.vgabase, 0x34) + 1) >> 1;
What's the warning? I'm not seeing anything on my machine when compiling
these two.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Joe Perches <joe@perches.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] framebuffer: Fix int cast to pointer warnings
Date: Tue, 26 Nov 2013 16:51:04 +0200 [thread overview]
Message-ID: <5294B558.6030106@ti.com> (raw)
In-Reply-To: <1379646611.2021.7.camel@joe-AO722>
[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]
On 2013-09-20 06:10, Joe Perches wrote:
> Casts of int to pointer need additional casts to (unsigned long)
> when compiled for x86-64 to silence the compiler.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/video/arkfb.c | 2 +-
> drivers/video/vt8623fb.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/arkfb.c b/drivers/video/arkfb.c
> index b13f3f2..26fd4e4 100644
> --- a/drivers/video/arkfb.c
> +++ b/drivers/video/arkfb.c
> @@ -1016,7 +1016,7 @@ static int ark_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>
> pcibios_bus_to_resource(dev, &vga_res, &bus_reg);
>
> - par->state.vgabase = (void __iomem *) vga_res.start;
> + par->state.vgabase = (void __iomem *)(unsigned long)vga_res.start;
>
> /* FIXME get memsize */
> regval = vga_rseq(par->state.vgabase, 0x10);
> diff --git a/drivers/video/vt8623fb.c b/drivers/video/vt8623fb.c
> index 7e97c53..281d41b 100644
> --- a/drivers/video/vt8623fb.c
> +++ b/drivers/video/vt8623fb.c
> @@ -731,7 +731,7 @@ static int vt8623_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>
> pcibios_bus_to_resource(dev, &vga_res, &bus_reg);
>
> - par->state.vgabase = (void __iomem *) vga_res.start;
> + par->state.vgabase = (void __iomem *)(unsigned long)vga_res.start;
>
> /* Find how many physical memory there is on card */
> memsize1 = (vga_rseq(par->state.vgabase, 0x34) + 1) >> 1;
What's the warning? I'm not seeing anything on my machine when compiling
these two.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-11-26 14:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 1:53 [PATCH 1/2] framebuffer: arkfb: Fix framebugger typo Joe Perches
2013-09-20 1:53 ` Joe Perches
2013-09-20 1:53 ` [PATCH 2/2] framebuffer: Remove pmag-aa-fb Joe Perches
2013-09-20 1:53 ` Joe Perches
2013-09-20 7:33 ` Geert Uytterhoeven
2013-09-20 7:33 ` Geert Uytterhoeven
2013-09-20 18:18 ` Maciej W. Rozycki
2013-09-20 18:18 ` Maciej W. Rozycki
2013-09-20 18:43 ` Joe Perches
2013-09-20 18:43 ` Joe Perches
2013-09-22 20:09 ` Maciej W. Rozycki
2013-09-22 20:09 ` Maciej W. Rozycki
2013-09-22 20:21 ` Geert Uytterhoeven
2013-09-22 20:21 ` Geert Uytterhoeven
2013-09-22 21:54 ` Maciej W. Rozycki
2013-09-22 21:54 ` Maciej W. Rozycki
2013-10-12 13:08 ` Maciej W. Rozycki
2013-10-12 13:08 ` Maciej W. Rozycki
2013-10-12 16:08 ` Joe Perches
2013-10-12 16:08 ` Joe Perches
2013-09-20 3:10 ` [PATCH 2/2] framebuffer: Fix int cast to pointer warnings Joe Perches
2013-09-20 3:10 ` Joe Perches
2013-11-26 14:51 ` Tomi Valkeinen [this message]
2013-11-26 14:51 ` Tomi Valkeinen
2013-09-26 9:47 ` [PATCH 1/2] framebuffer: arkfb: Fix framebugger typo Tomi Valkeinen
2013-09-26 9:47 ` Tomi Valkeinen
2013-09-26 10:10 ` Joe Perches
2013-09-26 10:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5294B558.6030106@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=joe@perches.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.