* [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
@ 2013-11-06 8:57 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2013-11-06 8:57 UTC (permalink / raw)
To: linux-arm-kernel
If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
drivers/video/sh_mobile_meram.c:573: warning: ‘sh_mobile_meram_suspend’ defined but not used
drivers/video/sh_mobile_meram.c:597: warning: ‘sh_mobile_meram_resume’ defined but not used
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v2: Both functions are used if CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME,
as pointed out by Laurent
drivers/video/sh_mobile_meram.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/sh_mobile_meram.c b/drivers/video/sh_mobile_meram.c
index e0f098562a74..a297de5cc859 100644
--- a/drivers/video/sh_mobile_meram.c
+++ b/drivers/video/sh_mobile_meram.c
@@ -569,6 +569,7 @@ EXPORT_SYMBOL_GPL(sh_mobile_meram_cache_update);
* Power management
*/
+#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
static int sh_mobile_meram_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
@@ -611,6 +612,7 @@ static int sh_mobile_meram_resume(struct device *dev)
meram_write_reg(priv->base, common_regs[i], priv->regs[i]);
return 0;
}
+#endif /* CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME */
static UNIVERSAL_DEV_PM_OPS(sh_mobile_meram_dev_pm_ops,
sh_mobile_meram_suspend,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
@ 2013-11-06 8:57 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2013-11-06 8:57 UTC (permalink / raw)
To: linux-arm-kernel
If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
drivers/video/sh_mobile_meram.c:573: warning: ?sh_mobile_meram_suspend? defined but not used
drivers/video/sh_mobile_meram.c:597: warning: ?sh_mobile_meram_resume? defined but not used
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v2: Both functions are used if CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME,
as pointed out by Laurent
drivers/video/sh_mobile_meram.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/sh_mobile_meram.c b/drivers/video/sh_mobile_meram.c
index e0f098562a74..a297de5cc859 100644
--- a/drivers/video/sh_mobile_meram.c
+++ b/drivers/video/sh_mobile_meram.c
@@ -569,6 +569,7 @@ EXPORT_SYMBOL_GPL(sh_mobile_meram_cache_update);
* Power management
*/
+#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
static int sh_mobile_meram_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
@@ -611,6 +612,7 @@ static int sh_mobile_meram_resume(struct device *dev)
meram_write_reg(priv->base, common_regs[i], priv->regs[i]);
return 0;
}
+#endif /* CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME */
static UNIVERSAL_DEV_PM_OPS(sh_mobile_meram_dev_pm_ops,
sh_mobile_meram_suspend,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
2013-11-06 8:57 ` Geert Uytterhoeven
@ 2013-11-06 11:57 ` Laurent Pinchart
-1 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2013-11-06 11:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Geert,
Thank you for the patch.
On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
> If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
>
> drivers/video/sh_mobile_meram.c:573: warning: ‘sh_mobile_meram_suspend’
> defined but not used drivers/video/sh_mobile_meram.c:597: warning:
> ‘sh_mobile_meram_resume’ defined but not used
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> v2: Both functions are used if CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME,
> as pointed out by Laurent
>
> drivers/video/sh_mobile_meram.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/sh_mobile_meram.c
> b/drivers/video/sh_mobile_meram.c index e0f098562a74..a297de5cc859 100644
> --- a/drivers/video/sh_mobile_meram.c
> +++ b/drivers/video/sh_mobile_meram.c
> @@ -569,6 +569,7 @@ EXPORT_SYMBOL_GPL(sh_mobile_meram_cache_update);
> * Power management
> */
>
> +#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
> static int sh_mobile_meram_suspend(struct device *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> @@ -611,6 +612,7 @@ static int sh_mobile_meram_resume(struct device *dev)
> meram_write_reg(priv->base, common_regs[i], priv->regs[i]);
> return 0;
> }
> +#endif /* CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME */
>
> static UNIVERSAL_DEV_PM_OPS(sh_mobile_meram_dev_pm_ops,
> sh_mobile_meram_suspend,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
@ 2013-11-06 11:57 ` Laurent Pinchart
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2013-11-06 11:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Geert,
Thank you for the patch.
On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
> If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
>
> drivers/video/sh_mobile_meram.c:573: warning: ?sh_mobile_meram_suspend?
> defined but not used drivers/video/sh_mobile_meram.c:597: warning:
> ?sh_mobile_meram_resume? defined but not used
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> v2: Both functions are used if CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME,
> as pointed out by Laurent
>
> drivers/video/sh_mobile_meram.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/sh_mobile_meram.c
> b/drivers/video/sh_mobile_meram.c index e0f098562a74..a297de5cc859 100644
> --- a/drivers/video/sh_mobile_meram.c
> +++ b/drivers/video/sh_mobile_meram.c
> @@ -569,6 +569,7 @@ EXPORT_SYMBOL_GPL(sh_mobile_meram_cache_update);
> * Power management
> */
>
> +#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
> static int sh_mobile_meram_suspend(struct device *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> @@ -611,6 +612,7 @@ static int sh_mobile_meram_resume(struct device *dev)
> meram_write_reg(priv->base, common_regs[i], priv->regs[i]);
> return 0;
> }
> +#endif /* CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME */
>
> static UNIVERSAL_DEV_PM_OPS(sh_mobile_meram_dev_pm_ops,
> sh_mobile_meram_suspend,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
2013-11-06 11:57 ` Laurent Pinchart
@ 2013-11-26 14:44 ` Tomi Valkeinen
-1 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2013-11-26 14:44 UTC (permalink / raw)
To: linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
Hi Laurent,
On 2013-11-06 13:57, Laurent Pinchart wrote:
> Hi Geert,
>
> Thank you for the patch.
>
> On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
>> If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
>>
>> drivers/video/sh_mobile_meram.c:573: warning: ‘sh_mobile_meram_suspend’
>> defined but not used drivers/video/sh_mobile_meram.c:597: warning:
>> ‘sh_mobile_meram_resume’ defined but not used
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> and applied to my tree.
What does that mean? Are you collecting sh_mobile video patches?
Or to rephrase, shall I apply this to fbdev fixes tree?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
@ 2013-11-26 14:44 ` Tomi Valkeinen
0 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2013-11-26 14:44 UTC (permalink / raw)
To: linux-arm-kernel
Hi Laurent,
On 2013-11-06 13:57, Laurent Pinchart wrote:
> Hi Geert,
>
> Thank you for the patch.
>
> On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
>> If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
>>
>> drivers/video/sh_mobile_meram.c:573: warning: ?sh_mobile_meram_suspend?
>> defined but not used drivers/video/sh_mobile_meram.c:597: warning:
>> ?sh_mobile_meram_resume? defined but not used
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> and applied to my tree.
What does that mean? Are you collecting sh_mobile video patches?
Or to rephrase, shall I apply this to fbdev fixes tree?
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131126/32fe24be/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
2013-11-26 14:44 ` Tomi Valkeinen
@ 2013-11-26 14:58 ` Laurent Pinchart
-1 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2013-11-26 14:58 UTC (permalink / raw)
To: linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
Hi Tomi,
On Tuesday 26 November 2013 16:44:09 Tomi Valkeinen wrote:
> On 2013-11-06 13:57, Laurent Pinchart wrote:
> > On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
> >> If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
> >>
> >> drivers/video/sh_mobile_meram.c:573: warning: ‘sh_mobile_meram_suspend’
> >> defined but not used drivers/video/sh_mobile_meram.c:597: warning:
> >> ‘sh_mobile_meram_resume’ defined but not used
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > and applied to my tree.
>
> What does that mean? Are you collecting sh_mobile video patches?
>
> Or to rephrase, shall I apply this to fbdev fixes tree?
I was planning to send you a pull request for that, but if you can pick it up
that's even easier, thanks.
--
Regards,
Laurent Pinchart
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
@ 2013-11-26 14:58 ` Laurent Pinchart
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2013-11-26 14:58 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tomi,
On Tuesday 26 November 2013 16:44:09 Tomi Valkeinen wrote:
> On 2013-11-06 13:57, Laurent Pinchart wrote:
> > On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
> >> If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
> >>
> >> drivers/video/sh_mobile_meram.c:573: warning: ?sh_mobile_meram_suspend?
> >> defined but not used drivers/video/sh_mobile_meram.c:597: warning:
> >> ?sh_mobile_meram_resume? defined but not used
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > and applied to my tree.
>
> What does that mean? Are you collecting sh_mobile video patches?
>
> Or to rephrase, shall I apply this to fbdev fixes tree?
I was planning to send you a pull request for that, but if you can pick it up
that's even easier, thanks.
--
Regards,
Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131126/9a4a3971/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
2013-11-26 14:58 ` Laurent Pinchart
@ 2013-11-26 15:00 ` Tomi Valkeinen
-1 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2013-11-26 15:00 UTC (permalink / raw)
To: linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
On 2013-11-26 16:58, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Tuesday 26 November 2013 16:44:09 Tomi Valkeinen wrote:
>> On 2013-11-06 13:57, Laurent Pinchart wrote:
>>> On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
>>>> If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
>>>>
>>>> drivers/video/sh_mobile_meram.c:573: warning: ‘sh_mobile_meram_suspend’
>>>> defined but not used drivers/video/sh_mobile_meram.c:597: warning:
>>>> ‘sh_mobile_meram_resume’ defined but not used
>>>>
>>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>>
>>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>>
>>> and applied to my tree.
>>
>> What does that mean? Are you collecting sh_mobile video patches?
>>
>> Or to rephrase, shall I apply this to fbdev fixes tree?
>
> I was planning to send you a pull request for that, but if you can pick it up
> that's even easier, thanks.
Ok. Applied, then, to fbdev =).
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
@ 2013-11-26 15:00 ` Tomi Valkeinen
0 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2013-11-26 15:00 UTC (permalink / raw)
To: linux-arm-kernel
On 2013-11-26 16:58, Laurent Pinchart wrote:
> Hi Tomi,
>
> On Tuesday 26 November 2013 16:44:09 Tomi Valkeinen wrote:
>> On 2013-11-06 13:57, Laurent Pinchart wrote:
>>> On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
>>>> If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
>>>>
>>>> drivers/video/sh_mobile_meram.c:573: warning: ?sh_mobile_meram_suspend?
>>>> defined but not used drivers/video/sh_mobile_meram.c:597: warning:
>>>> ?sh_mobile_meram_resume? defined but not used
>>>>
>>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>>
>>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>>
>>> and applied to my tree.
>>
>> What does that mean? Are you collecting sh_mobile video patches?
>>
>> Or to rephrase, shall I apply this to fbdev fixes tree?
>
> I was planning to send you a pull request for that, but if you can pick it up
> that's even easier, thanks.
Ok. Applied, then, to fbdev =).
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131126/89bb7bcc/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-11-26 15:00 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-06 8:57 [PATCH -v2] fbdev: sh_mobile_meram: Fix defined but not used compiler warnings Geert Uytterhoeven
2013-11-06 8:57 ` Geert Uytterhoeven
2013-11-06 11:57 ` Laurent Pinchart
2013-11-06 11:57 ` Laurent Pinchart
2013-11-26 14:44 ` Tomi Valkeinen
2013-11-26 14:44 ` Tomi Valkeinen
2013-11-26 14:58 ` Laurent Pinchart
2013-11-26 14:58 ` Laurent Pinchart
2013-11-26 15:00 ` Tomi Valkeinen
2013-11-26 15:00 ` Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.