All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Load message_center and message_proxy from the provider info file
@ 2013-11-25 22:00 Slava Monich
  2013-11-26 21:37 ` Denis Kenzior
  0 siblings, 1 reply; 3+ messages in thread
From: Slava Monich @ 2013-11-25 22:00 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-Load-message_center-and-message_proxy-from-the-provi.patch --]
[-- Type: application/octet-stream, Size: 1058 bytes --]

From 5f9df36c2daed81a2cd563788040b63c9805cf32 Mon Sep 17 00:00:00 2001
From: Slava Monich <slava.monich@jolla.com>
Date: Mon, 25 Nov 2013 23:51:53 +0200
Subject: [PATCH] Load message_center and message_proxy from the provider info
 file

---
 plugins/mbpi.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/plugins/mbpi.c b/plugins/mbpi.c
index 309e1ed..17ba4d8 100644
--- a/plugins/mbpi.c
+++ b/plugins/mbpi.c
@@ -174,6 +174,12 @@ static void apn_start(GMarkupParseContext *context, const gchar *element_name,
 	else if (g_str_equal(element_name, "password"))
 		g_markup_parse_context_push(context, &text_parser,
 						&apn->password);
+	else if (g_str_equal(element_name, "mmsc"))
+		g_markup_parse_context_push(context, &text_parser,
+						&apn->message_center);
+	else if (g_str_equal(element_name, "mmsproxy"))
+		g_markup_parse_context_push(context, &text_parser,
+						&apn->message_proxy);
 	else if (g_str_equal(element_name, "usage"))
 		usage_start(context, attribute_names, attribute_values,
 				&apn->type, error);
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Load message_center and message_proxy from the provider info file
  2013-11-25 22:00 [PATCH] Load message_center and message_proxy from the provider info file Slava Monich
@ 2013-11-26 21:37 ` Denis Kenzior
  2013-11-27  8:40   ` Slava Monich
  0 siblings, 1 reply; 3+ messages in thread
From: Denis Kenzior @ 2013-11-26 21:37 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

Hi Slava,

I went ahead and applied the patch.  Please note that this logic will 
only work if Mobile Broadband Provider Info marks the context as usage=mms.

Also, in the future please use git send-email to submit patches.

Thanks,
-Denis

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Load message_center and message_proxy from the provider info file
  2013-11-26 21:37 ` Denis Kenzior
@ 2013-11-27  8:40   ` Slava Monich
  0 siblings, 0 replies; 3+ messages in thread
From: Slava Monich @ 2013-11-27  8:40 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

OK, thanks!

-Slava


> Hi Slava,
> 
> I went ahead and applied the patch.  Please note that this logic will only work if Mobile Broadband Provider Info marks the context as usage=mms.
> 
> Also, in the future please use git send-email to submit patches.
> 
> Thanks,
> -Denis


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-11-27  8:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-25 22:00 [PATCH] Load message_center and message_proxy from the provider info file Slava Monich
2013-11-26 21:37 ` Denis Kenzior
2013-11-27  8:40   ` Slava Monich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.