From: Hannes Reinecke <hare@suse.de>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: Re: [PATCH 6/9] multipathd: Implement systemd watchdog integration
Date: Wed, 27 Nov 2013 08:05:12 +0100 [thread overview]
Message-ID: <529599A8.1020407@suse.de> (raw)
In-Reply-To: <20131126184110.GO1661@dhcp80-209.msp.redhat.com>
On 11/26/2013 07:41 PM, Benjamin Marzinski wrote:
> On Tue, Nov 26, 2013 at 12:41:27PM +0100, Hannes Reinecke wrote:
>> In the past there have been several instances where multipathd
>> would hang with the checkerloop as some path checker might not
>> be able to return in time.
>> This patch now activates the watchdog feature from systemd
>> to shutdown (and possibly restart) multipathd in these
>> situations.
>> Due to a bug in systemd watchdog integration only works
>> correctly with later version (> 206), so watchdog integration
>> has been disabled per default on earlier implementations.
>
> I'm still not sure what having multipath restarted gets us. Is the hope
> that on restart, multipath will simply be unable to access the path, and
> it will fail there quicker that the checker would? Otherwise, the
> checker will likely get stuck in the same place on the restart. Also,
> the checker can get stuck in uninterruptible sleep. In this case,
> systemd isn't going to be able to to restart multipathd until the issue
> has already cleared up.
>
Most cases I've come across where the checkerloop was hanging it was
_not_ due to an uninterruptible sleep, but rather a bug in some odd
cornercase. So there it definitely would make sense.
And if you don't like the 'restart' behaviour you can easily switch
it off by just editing the service file.
In general the watchdog integration (with or without restart) is
a _very_ useful thing, as multipathd hanging is a pain to debug
on a customer site. If systemd notifies this debugging becomes
_way_ easier.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2013-11-27 7:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 11:41 [PATCH 0/9] multipath systemd integration Hannes Reinecke
2013-11-26 11:41 ` [PATCH 1/9] Clarify uxsock logging Hannes Reinecke
2013-11-26 11:41 ` [PATCH 2/9] Use system-provided regex implementation Hannes Reinecke
2013-11-26 11:41 ` [PATCH 3/9] multipathd: Add option '-s' to suppress timestamps Hannes Reinecke
2013-11-26 11:41 ` [PATCH 4/9] multipathd: switch to socket activation for systemd Hannes Reinecke
2013-11-26 11:41 ` [PATCH 5/9] multipathd: use sd_notify() to inform systemd Hannes Reinecke
2013-11-26 11:41 ` [PATCH 6/9] multipathd: Implement systemd watchdog integration Hannes Reinecke
2013-11-26 18:41 ` Benjamin Marzinski
2013-11-27 7:05 ` Hannes Reinecke [this message]
2013-11-26 11:41 ` [PATCH 7/9] multipathd: enable core dumps for systemd Hannes Reinecke
2013-11-26 11:41 ` [PATCH 8/9] multipathd: Read environment variables from systemd Hannes Reinecke
2013-11-26 11:41 ` [PATCH 9/9] multipathd: measure path check time Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529599A8.1020407@suse.de \
--to=hare@suse.de \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@gmail.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.