From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: at91sam9: include <mach/hardware.h> explicitly
Date: Wed, 27 Nov 2013 09:49:33 +0100 [thread overview]
Message-ID: <5295B21D.5020308@atmel.com> (raw)
In-Reply-To: <20131115145554.GC19318@pengutronix.de>
On 15/11/2013 15:55, Uwe Kleine-K?nig :
> Hello,
>
> On Fri, Nov 15, 2013 at 03:23:27PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 15:00 Fri 15 Nov , Uwe Kleine-K??nig wrote:
>>> The driver needs the symbol AT91_SLOW_CLOCK which is defined in
>>> arch/arm/mach-at91/include/mach/hardware.h. This file is included
>>> implicitly via linux/module.h -> linux/kmod.h -> linux/gfp.h ->
>>> linux/mmzone.h -> linux/memory_hotplug.h -> linux/notifier.h ->
>>> linux/srcu.h -> linux/workqueue.h -> linux/timer.h -> linux/ktime.h ->
>>> linux/jiffies.h -> linux/timex.h -> mach/timex.h -> mach/hardware.h .
>>>
>>> So better include it explicitly not only because the last link will go
>>> away soon.
>>>
>>> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
>>
>> we should never use this symbol you need to request the clock clk32k
> IMHO this should be addressed in another patch. My intent is to get rid
> of <mach/timex.h>. So I let someone else take this patch opportunity.
I understand the objective of this patch.
So, in the meantime, you have my:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
(if it is not too late, Uwe).
Thanks for addressing that, bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2013-11-27 8:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 14:00 [PATCH] rtc: at91sam9: include <mach/hardware.h> explicitly Uwe Kleine-König
2013-11-15 14:23 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-15 14:55 ` Uwe Kleine-König
2013-11-27 8:49 ` Nicolas Ferre [this message]
2013-11-26 13:41 ` Uwe Kleine-König
2013-11-26 13:44 ` Uwe Kleine-König
2013-11-26 18:36 ` Uwe Kleine-König
2013-12-16 8:11 ` Andrew Morton
2013-12-16 19:28 ` Uwe Kleine-König
2013-12-16 22:46 ` Andrew Morton
2013-12-17 8:15 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295B21D.5020308@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.